Add ink! smart-contract #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods implemented so far: - new - update_creation_fees - create_canvas - edit_canvas - capture_cell - change_cell_color - change_multiple_cells_color - get_game_details - get_canvas_details - get_grid_details - get_cell_details - get_user_created_canvas_ids - get_user_participated_canvas_ids
- collect_fees - mint_canvas - get_canvas_stats - get_user_cash_flow - get_user_nfts - get_owned_nft_count
realnimish
force-pushed
the
smart-contract
branch
from
2a4f89e
to
5aaf487
Compare
- Improved Error messages - Added checks to prevent user from creating non-functional canvas - Disallowed owner to recapture their own tokens
- add_sudo - remove_sudo - has_sudo_powers - capture_multiple_cells
- Introduced commission charges on cell capture - Added get_canvases_by_popularity()
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice work!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The given implementation follows single-contract model which can be made ERC1155 compliant or ERC721 compliant (if complex
tokenIdallowed or we encode the complex key to u128) in the future.Multi-contract model was avoided primarily because of the lack of event support in the cross-call contract environment (use-ink/ink#1000); otherwise a much simpler/elegant ERC721 impl could have been followed.
Additional notes
Path to ERC1155 compliance
Path to ERC721 compliance