-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow updating existing checks #81
Allow updating existing checks #81
Conversation
a57afa2
to
e071304
Compare
@nineinchnick thank you for your contribution. Could you resolve the conflicts so we can take a look? |
e071304
to
85ad689
Compare
@ghaiszaher all done! |
@nineinchnick thank you. Could you please update from Same for the other PR #82 |
85ad689
to
bf6164a
Compare
Done! |
Still not working, I can't figure out the correct permissions needed, it could also be related to organization settings. We'll have a look at it later. If you have any ideas let me know. |
Workflows running on forks can only have read permissions for the token: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token This is because they can potentially run untrusted code, without requiring maintainer approval. We're using this action in the Trino project and we had set up a separate workflow to annotate PRs based on test reports saved as artifacts: https://github.com/trinodb/trino/blob/master/.github/workflows/annotate.yml Notice this is triggered on workflow runs, not PRs, so it executes with a more privileged token. This probably should be documented here, since it affects anyone that would try to use this action in a public repository. |
I just found an issue for this: #50 |
@nineinchnick thanks for the insights, let's track this in #50. |
Allow updating existing checks instead of always creating a new one.
I had to update Github dependencies to access
github.context.job
, which was added a year ago or so.Without this, there's always a new check run created, with only annotations (example run):
With this change, annotations are added to existing jobs, without cluttering the list of jobs (example run):