Fix several small issues #3705
Merged
Fix several small issues #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
hyperupcall
force-pushed
the
hyperupcall-smallfixes
branch
5 times, most recently
from
33437ec
to
c3ebf5e
Compare
hyperupcall
force-pushed
the
hyperupcall-smallfixes
branch
from
c3ebf5e
to
d18744c
Compare
github-actions
bot
removed
ci
jnoordsij
reviewed
May 14, 2024
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft-04/schema#", | |||
| "allowTrailingCommas": true, | |||
There was a problem hiding this comment.
Is there a particular reason this was removed? I was so happy that trailing commas were allowed due to this, given that things function perfectly with trailing commas, only to discover that now again they are highlighted as invalid in my IDE.
If this is intentional all fine, just double checking before I remove all trailing commas once more from my code.
There was a problem hiding this comment.
Oh you're right, I made a mistake removing this. I believe I removed it because the same property didn't exist in jsconfig.json, but now i'll add it to both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several small issues.
closes #3504
closes #3702
closes #3108
closes #3116
closes #3364