Support schildichat protocol #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
su-ex
reviewed
Mar 4, 2022
AndrewRyanChama
force-pushed
the
ar/desktopprotocol
branch
from
a854144
to
953361e
Compare
Currently, the desktop app supports element:// but there is no specific protocol for schildichat. This change adds support for schildichat:// in addition to element://
AndrewRyanChama
force-pushed
the
ar/desktopprotocol
branch
from
953361e
to
4114f60
Compare
su-ex
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the desktop app supports element:// but there is no specific
protocol for schildichat. This change adds support for schildichat:// in
addition to element://
Tested on crapos but not linux or windows
schildichat://vector/webapp/#/room%2F%23web%3Aschildi.chat
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.