Re-enable the ability to toggle the 'home' metaspace #5
Conversation
Useful for people who want SchildiChat to act more like other chat platforms (i.e. by having just People and Other meta-spaces) Commit 4540cf5 disabled the ability to turn the Home meta-space on/off for... *some reason*. Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 660 York Street, Suite 102, San Francisco, CA 94110 USA Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: 20kdc <[email protected]>
|
Right, there should be nothing wrong with having the option. I'll test it later when I get back to working on SchildiChat. |
|
In my experience, "Rooms outside of a space" covers this additional meta space you describe. For example I just have the People and Other Rooms meta-spaces and things work fine for me. |
|
That might be, but this way it's a requirement not to use any custom space, which might not be an option for some. |
|
I'm not quite sure what that means. |
|
Yes, exactly. |
|
Can that be an option on what is presently "Rooms outside of a space", or should it be a separate meta-space altogether? |
|
Actually, why does using "other rooms" add a requirement to use a custom space exactly? It only excludes rooms when a space already exists to put them in. |
And that's the problem. There is no meta space to show all non DM rooms, independent of the existence of other spaces. Thus, currently it's a requirement not to use any custom spaces if you want a meta space grouping all non DM rooms. Anyway, that's probably not really related to this change. It's just the timely relation that showed me how different people use spaces and that not every usecase is currently covered. For example, I don't want any of the meta spaces except home, you only want the meta spaces and others want a mixture. |
|
I attempted to work on the problem, but I can't really navigate this code very well (it seems like there's an awful lot of code required to add a meta-space, and changing the behaviour of an existing one appears worse, somehow), and the OpenSSL problems make testing difficult. That in mind my view is that simply allowing Home to be disabled is at least an improvement. |
|
Yes, indeed. If it works when I test this later, I'll just merge it. Adding another meta space or an option like the one for home to exclude rooms inside other spaces or not can be added later. |
|
This seems fine, thanks for your contribution! |
**Big important warning: Due to OpenSSL issues, I was not able to get the build environment functional on my system. This is a two-line change. Someone please test this. **
Useful for people who want SchildiChat to act more like other chat platforms (i.e. by having just People and Other meta-spaces)
Commit 4540cf5 disabled the ability to turn the Home meta-space on/off for... some reason.
A sign-off has been included in the commit.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.