-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write is_nondesc() to check whether variables are in non-descending order #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to go back and add references to PRs for other functions too
kelly-sovacool
requested review from
a team and
sklucas
and removed request for
a team
November 7, 2021 19:52
This sounds like a sound method for checking your work. |
sklucas
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to
close_enough()
, I like to useis_nondesc()
paired with theassertthat
package to make sure that claims I make in a manuscript are true. If you re-run your code or a pipeline, numbers could change slightly, and you'll want to be sure that your overall conclusions did not change. For example, if I make a claim that "x is less than y and y is less than z", then I also include a hidden code chunk withassert_that(is_nondesc(x, y, z))
.Checklist
(
Strikethroughany points that are not applicable.)NEWS.md
if this includes any user-facing changes.