Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_wildcards_tbl() - don't overwrite the seed #48

Merged
merged 7 commits into from
Jan 16, 2023

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Jan 16, 2023

Don't assume the seed is in wildcards. Let the user handle overwriting/converting it.

Checklist

(Strikethrough any points that are not applicable.)

  • Write unit tests for any new functionality.
  • [ ] Update roxygen comments & vignettes if there are any API changes.
  • Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review January 16, 2023 20:08
@kelly-sovacool kelly-sovacool merged commit 89bc997 into main Jan 16, 2023
@kelly-sovacool kelly-sovacool deleted the smk-wildcards-fix branch January 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant