Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): generate scripts with executable permission #120

Merged
merged 1 commit into from
May 24, 2022
Merged

fix(template): generate scripts with executable permission #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions pkg/gotemplate/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ import (
)

const (
minGoVersion = "1.15"
permissionDirectory = 0755
permissionFile = 0644
minGoVersion = "1.15"
permissionRWX = 0755
permissionRW = 0644
)

var (
Expand Down Expand Up @@ -211,7 +211,7 @@ func (gt *GT) InitNewProject(opts *NewRepositoryOptions) (err error) {

pathToWrite = strings.ReplaceAll(pathToWrite, gotemplate.Key, targetDir)
if d.IsDir() {
return os.MkdirAll(pathToWrite, permissionDirectory)
return os.MkdirAll(pathToWrite, permissionRWX)
}

fileBytes, err := fs.ReadFile(gotemplate.FS, path)
Expand All @@ -224,7 +224,13 @@ func (gt *GT) InitNewProject(opts *NewRepositoryOptions) (err error) {
return err
}

return os.WriteFile(pathToWrite, []byte(data), permissionFile)
filePermissions := fs.FileMode(permissionRW)
// files that contain a shebang should be executable
if strings.HasPrefix(strings.TrimSpace(data), "#!") {
filePermissions = permissionRWX
}

return os.WriteFile(pathToWrite, []byte(data), filePermissions)
})
if err != nil {
return err
Expand Down