feat(template): replace openapiv2 generator with gnostic #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxluigi
reviewed
Aug 24, 2022
linuxluigi
reviewed
Aug 24, 2022
|
Looks good to me, will try to find some time today to test your code |
brumhard
suggested changes
Oct 8, 2022
There was a problem hiding this comment.
Hi there,
sry for keeping you waiting for so long. I really appreciate the effort. In fact, I've been looking for a way to create openapiv3 specs for a long time so this is a great addition 👍🏻
I found a few minor things while testing.
Also since it's not included in the PR: could you also fix _template/buf.gen.yaml and rename
- name: openapiv2
out: api/openapi
to
- name: openapi
out: api/openapi
Thank you very much :)
_template/api/proto/{{.Base.appName}}/v1/{{.Base.appName}}.proto
Outdated
Show resolved
Hide resolved
linuxluigi
changed the title
linuxluigi
approved these changes
Nov 4, 2022
brumhard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current openapiv2 generator for the oas with openapi from gnostic. The annotations for v3 were imported in the template proto file, instead of the v2 ones.