Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final release 2.0.0 #216

Closed
6 tasks done
mxochicale opened this issue May 3, 2023 · 4 comments
Closed
6 tasks done

Final release 2.0.0 #216

mxochicale opened this issue May 3, 2023 · 4 comments
Assignees
Labels

Comments

@mxochicale
Copy link
Contributor

mxochicale commented May 3, 2023

I am opening this issue to plan final release 2.0.0 from the release candicate v2.0rc0 which was published on this 8 Mar 2023 for g PySide6.

Thanks,
Miguel

Summary

Unit tests and coverage for py38

The following sections are brief summaries of local and remote unit tests and coverage. See more for remote tests: https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4884138539

local ubuntu22.04x64

# pytest -v -s tests
============ 154 passed, 9 skipped, 13 warnings in 25.55s ============

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK pipelines and pyside workflo...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK p...)
tests/widgets/test_lus_simulator.py::test_basic_rendering_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME because of issues with VTK pipe...)
tests/widgets/test_lus_simulator.py::test_matrices_rendering_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME because of issues with VTK p...)
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK pi...)
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator_zbuffer SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues wit...)
tests/widgets/test_rendering_generator.py::test_mask_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK pipelines and...)
tests/widgets/test_rendering_generator.py::test_mask_generator_w_all_shading SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK...)
tests/widgets/test_rendering_generator.py::test_mask_generator_w_some_shading SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VT...)

py38: commands[2]> coverage report -m
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk/camera/__init__.py                                 0      0   100%
sksurgeryvtk/camera/vtk_camera_model.py                        82      8    90%   20-23, 161, 164, 175-176
sksurgeryvtk/models/__init__.py                                 0      0   100%
sksurgeryvtk/models/outline_render.py                          14      0   100%
sksurgeryvtk/models/surface_model_loader.py                    83      6    93%   103, 108, 113, 118, 123, 148
sksurgeryvtk/models/voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk/models/vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk/models/vtk_base_model.py                          40      1    98%   101
sksurgeryvtk/models/vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk/models/vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk/models/vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk/models/vtk_point_model.py                         57      1    98%   104
sksurgeryvtk/models/vtk_sphere_model.py                        45      0   100%
sksurgeryvtk/models/vtk_surface_model.py                      120      3    98%   62, 161, 242
sksurgeryvtk/models/vtk_surface_model_directory_loader.py     100      7    93%   55, 136-139, 142-143, 193
sksurgeryvtk/text/__init__.py                                   0      0   100%
sksurgeryvtk/text/text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk/utils/__init__.py                                  0      0   100%
sksurgeryvtk/utils/matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk/utils/platform_utils.py                            7      7     0%   3-19
sksurgeryvtk/utils/polydata_utils.py                           31      0   100%
sksurgeryvtk/utils/projection_utils.py                         66      1    98%   43
sksurgeryvtk/widgets/__init__.py                                0      0   100%
sksurgeryvtk/widgets/vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk/widgets/vtk_lus_simulator.py                      87     77    11%   47-95, 122-177, 191-221
sksurgeryvtk/widgets/vtk_overlay_window.py                    234     36    85%   81, 169, 178-179, 183-184, 198, 267, 368, 388, 393-397, 424, 433-434, 440, 446, 462-469, 499-514, 522-527
sksurgeryvtk/widgets/vtk_rendering_generator.py               105     83    21%   53-93, 97-98, 107-109, 118-119, 125-131, 153-161, 170-174, 182-190, 197-206, 220-243
sksurgeryvtk/widgets/vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    445    78%

CI ubuntu-latest, 3.8

============ 156 passed, 7 skipped, 13 warnings in 81.63s (0:01:21) ============

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Linux ...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator SKIPPED
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator_zbuffer SKIPPED
tests/widgets/test_rendering_generator.py::test_mask_generator SKIPPED
tests/widgets/test_rendering_generator.py::test_mask_generator_w_all_shading SKIPPED
tests/widgets/test_rendering_generator.py::test_mask_generator_w_some_shading SKIPPED


Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk/camera/__init__.py                                 0      0   100%
sksurgeryvtk/camera/vtk_camera_model.py                        82      4    95%   161, 164, 175-176
sksurgeryvtk/models/__init__.py                                 0      0   100%
sksurgeryvtk/models/outline_render.py                          14      0   100%
sksurgeryvtk/models/surface_model_loader.py                    83      6    93%   103, 108, 113, 118, 123, 148
sksurgeryvtk/models/voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk/models/vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk/models/vtk_base_model.py                          40      1    98%   101
sksurgeryvtk/models/vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk/models/vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk/models/vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk/models/vtk_point_model.py                         57      1    98%   104
sksurgeryvtk/models/vtk_sphere_model.py                        45      0   100%
sksurgeryvtk/models/vtk_surface_model.py                      120      2    98%   161, 242
sksurgeryvtk/models/vtk_surface_model_directory_loader.py     100      7    93%   55, 136-139, 142-143, 193
sksurgeryvtk/text/__init__.py                                   0      0   100%
sksurgeryvtk/text/text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk/utils/__init__.py                                  0      0   100%
sksurgeryvtk/utils/matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk/utils/platform_utils.py                            7      7     0%   3-19
sksurgeryvtk/utils/polydata_utils.py                           31      0   100%
sksurgeryvtk/utils/projection_utils.py                         66      1    98%   43
sksurgeryvtk/widgets/__init__.py                                0      0   100%
sksurgeryvtk/widgets/vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk/widgets/vtk_lus_simulator.py                      87      0   100%
sksurgeryvtk/widgets/vtk_overlay_window.py                    234     34    85%   81, 169, 178-179, 198, 267, 368, 388, 393-397, 424, 433-434, 440, 446, 462-469, 499-514, 522-527
sksurgeryvtk/widgets/vtk_rendering_generator.py               105     21    80%   118-119, 154, 157, 170-174, 182-190, 202, 227-228, 241
sksurgeryvtk/widgets/vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    299    85%

CI windows-latest, 3.8

=========== 161 passed, 2 skipped, 13 warnings in 68.24s (0:01:08) ============

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Window...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED



Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk\camera\__init__.py                                 0      0   100%
sksurgeryvtk\camera\vtk_camera_model.py                        82      4    95%   161, 164, 175-176
sksurgeryvtk\models\__init__.py                                 0      0   100%
sksurgeryvtk\models\outline_render.py                          14      0   100%
sksurgeryvtk\models\surface_model_loader.py                    83      5    94%   103, 108, 113, 118, 123
sksurgeryvtk\models\voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, [406](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4884138539/jobs/8716445453#step:7:407), 495, 502-503, 507, 519, 594-596
sksurgeryvtk\models\vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk\models\vtk_base_model.py                          40      1    98%   101
sksurgeryvtk\models\vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk\models\vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk\models\vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk\models\vtk_point_model.py                         57      1    98%   104
sksurgeryvtk\models\vtk_sphere_model.py                        45      0   100%
sksurgeryvtk\models\vtk_surface_model.py                      120      2    98%   161, 242
sksurgeryvtk\models\vtk_surface_model_directory_loader.py     100     10    90%   55, 57, 59, 136-139, 142-143, 167, 193
sksurgeryvtk\text\__init__.py                                   0      0   100%
sksurgeryvtk\text\text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk\utils\__init__.py                                  0      0   100%
sksurgeryvtk\utils\matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk\utils\platform_utils.py                            7      7     0%   3-19
sksurgeryvtk\utils\polydata_utils.py                           31      0   100%
sksurgeryvtk\utils\projection_utils.py                         66      1    98%   43
sksurgeryvtk\widgets\__init__.py                                0      0   100%
sksurgeryvtk\widgets\vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk\widgets\vtk_lus_simulator.py                      87      0   100%
sksurgeryvtk\widgets\vtk_overlay_window.py                    234     25    89%   81, 178-179, 198, 267, 368, 388, 393-397, [424](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4884138539/jobs/8716445453#step:7:425), 433-434, 440, 446, 499-514, 522-527
sksurgeryvtk\widgets\vtk_rendering_generator.py               105      0   100%
sksurgeryvtk\widgets\vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    271    86%

CI macos-latest, 3.8


=========== 161 passed, 2 skipped, 13 warnings in 189.63s (0:03:09) ============

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Darwin...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED


Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk/camera/__init__.py                                 0      0   100%
sksurgeryvtk/camera/vtk_camera_model.py                        82      4    95%   161, 164, 175-176
sksurgeryvtk/models/__init__.py                                 0      0   100%
sksurgeryvtk/models/outline_render.py                          14      0   100%
sksurgeryvtk/models/surface_model_loader.py                    83      5    94%   103, 108, 113, 118, 123
sksurgeryvtk/models/voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk/models/vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk/models/vtk_base_model.py                          40      1    98%   101
sksurgeryvtk/models/vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk/models/vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk/models/vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk/models/vtk_point_model.py                         57      1    98%   104
sksurgeryvtk/models/vtk_sphere_model.py                        45      0   100%
sksurgeryvtk/models/vtk_surface_model.py                      120      2    98%   161, 242
sksurgeryvtk/models/vtk_surface_model_directory_loader.py     100      7    93%   55, 136-139, 142-143, 193
sksurgeryvtk/text/__init__.py                                   0      0   100%
sksurgeryvtk/text/text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk/utils/__init__.py                                  0      0   100%
sksurgeryvtk/utils/matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk/utils/platform_utils.py                            7      7     0%   3-19
sksurgeryvtk/utils/polydata_utils.py                           31      0   100%
sksurgeryvtk/utils/projection_utils.py                         66      1    98%   43
sksurgeryvtk/widgets/__init__.py                                0      0   100%
sksurgeryvtk/widgets/vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk/widgets/vtk_lus_simulator.py                      87      0   100%
sksurgeryvtk/widgets/vtk_overlay_window.py                    234     25    89%   81, 178-179, 198, 267, 368, 388, 393-397, [424](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4884138539/jobs/8716445814#step:7:425), [433](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4884138539/jobs/8716445814#step:7:434)-[434](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4884138539/jobs/8716445814#step:7:435), 440, 446, 499-514, 522-527
sksurgeryvtk/widgets/vtk_rendering_generator.py               105      0   100%
sksurgeryvtk/widgets/vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    268    87%



For future work

@mxochicale mxochicale self-assigned this May 3, 2023
@mxochicale
Copy link
Contributor Author

mxochicale commented May 3, 2023

  • Running tox locally in Operating System: Ubuntu 22.04.1 LTS with Kernel: Linux 5.19.0-40-generic and Architecture: x86-64
  • SORTED OUT ✔️ ERROR qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
export DISPLAY=:1
export QT_QPA_PLATFORM=offscreen
https://github.com/NVlabs/instant-ngp/discussions/300
  • SORTED OUT ✔️ ERROR qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
QT_QPA_PLATFORM=xcb
SOLUTION: export QT_QPA_PLATFORM=offscreen
Edit: Environment variable `QT_QPA_PLATFORM=xcb` will force Qt to use X11 instead of Wayland.
https://gitlab.kitware.com/vtk/vtk/-/issues/18701
  • SORTED OUT ✔️ ERROR qt.dbus.integration: Could not connect "org.freedesktop.IBus" to globalEngineChanged(QString)
SOLUTION: pkill ibus-x11
https://forum.qt.io/topic/144309/not-connect-org-freedesktop-ibus/4
  • 🔴 ERROR: X Error of failed request: BadWindow (invalid Window parameter)
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  2 (X_ChangeWindowAttributes)
  Resource id in failed request:  0x1
  Serial number of failed request:  7
  Current serial number in output stream:  9
  • 🔴 Same ERROR: X Error of failed request: BadWindow (invalid Window parameter)
export LIBGL_ALWAYS_SOFTWARE=1
export LIBGL_ALWAYS_SOFTWARE=0
https://gitlab.kitware.com/vtk/vtk/-/issues/18701
  • 🔴 Same ERROR: X Error of failed request: BadWindow (invalid Window parameter)
QT_QPA_BACKEND=xcb
QT_QPA_BACKEND=offscreen
https://gitlab.kitware.com/vtk/vtk/-/issues/18701
  • SORTED OUT ✔️ X Error of failed request: BadWindow (invalid Window parameter)
sudo apt-get install libxcb-cursor-dev
export QT_QPA_PLATFORM=xcb

@thompson318
Copy link
Collaborator

For the "Could not load the Qt platform plugin "xcb" in "" even though it was found" errors I found this whilst doing SciKit-Surgery/snappysonic#26. I ran ldd .tox/py38/lib/python3.8/site-packages/PySide6/Qt/plugins/platforms/libqxcb.so which told me which linked libraries were missing. Then sudo apt-get install libxcb-cursor-dev fixed it.

@mxochicale
Copy link
Contributor Author

mxochicale commented May 4, 2023

Any suggestion for the following error?
I have tried some of these https://gitlab.kitware.com/vtk/vtk/-/issues/18701 but still not able to sort it out

X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  2 (X_ChangeWindowAttributes)
  Resource id in failed request:  0x1
  Serial number of failed request:  7
  Current serial number in output stream:  9
  • SORTED OUT ✔️ locally and remotely with this two lines in terminal and ci.yml, respectively:
sudo apt-get install libxcb-cursor-dev
export QT_QPA_PLATFORM=xcb

mxochicale added a commit that referenced this issue May 4, 2023
mxochicale added a commit that referenced this issue May 4, 2023
mxochicale added a commit that referenced this issue May 4, 2023
mxochicale added a commit that referenced this issue May 4, 2023
mxochicale added a commit that referenced this issue May 9, 2023
mxochicale added a commit that referenced this issue May 10, 2023
mxochicale added a commit that referenced this issue May 10, 2023
mxochicale added a commit that referenced this issue May 22, 2023
…aced_stereo_window, vtk_rendering_generator, vtk_reslice_widget,models.vtk_surface_model, models.vtk_surface_model_directory_loader, models.vtk_grid_model, models.vtk_image_model, models.vtk_point_model, models.vtk_sphere_model, text.text_overlay, utils.matrix_utils, utils.projection_utils, utils.polydata_utils, in docs/module_ref.rst (#216, #217)
mxochicale added a commit that referenced this issue May 23, 2023
mxochicale added a commit that referenced this issue May 24, 2023
mxochicale added a commit that referenced this issue May 24, 2023
@mxochicale
Copy link
Contributor Author

Closing this one with release notes Scikit-SurgeryVTK 2.0.0 Release: compatible with vt v9.2.6 and PySide6 v6.5.0 Latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants