use Enzyme make_zero #1054
Merged
use Enzyme make_zero #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Jun 6, 2024
| for v in dres.u | ||
| v .= 0 | ||
| end | ||
| dres = Enzyme.make_zero(dres) |
There was a problem hiding this comment.
@ChrisRackauckas this is incorrect.
It will not update the values of dres in place, instead allocating a new variable.
This will lead to correctness issues if the rule is called within a loop.
There was a problem hiding this comment.
is there a make_zero!(v) we can use?
There was a problem hiding this comment.
not yet, but I'll start making one. We haven't historically seen too much of a need for and always gottena way with the broadcast to zero (like here). But obviously generic structs need generic zeros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Enzyme's
make_zeroutil instead of manually zeroing out the derivative variable.Needed for SciML/NonlinearSolve.jl#439 to make the Enzyme rule compatible with
NonlinearProblem