add integrator accessors for dispatch purposes #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
changed the title
This was referenced Aug 12, 2024
src/integrator_accessors.jl
Outdated
Comment on lines
4
to
5
| # returns if the given integrator has an integ.iter field | ||
| hasiter(integ) = true |
There was a problem hiding this comment.
hasfield and hasproperty work at compile time though, so I'm not sure if this one is the most essential?
There was a problem hiding this comment.
Ok, I wasn’t sure about if hasfield is compile time, but since it is I can drop this.
isaacsas
changed the title
This was referenced Aug 13, 2024
|
OK, I think this is good to go along with the followup PRs
as far as I can tell ODEInterfaceDiffEq doesn't support |
|
Format failures seem to be in other files so can be handled in a separate PR. |
|
I removed the alias keyword. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for SciML/DiffEqCallbacks.jl#229, but shouldn't get merged until we are settled that SciML/DiffEqCallbacks.jl#229 has the correct approach (and doesn't need changes here).