Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments passed to IntegralProblems are ignored #255

Closed
rkube opened this issue Aug 23, 2024 · 6 comments
Closed

Arguments passed to IntegralProblems are ignored #255

rkube opened this issue Aug 23, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@rkube
Copy link

rkube commented Aug 23, 2024

Hi,
I'm trying to pass arguments to my integrand when instantiating an IntegralProblem, but the integrand only ever receives a SciMLBase.NullParameters().

MWE:

using Integrals

x_d = (0.16, 0.0, 0.1)
# Detector diameter
d = 0.02 
# Source location
x_s = (0.0, 0.0, 0.05)
function distance_source_surface(r_det, r_src, r_surf)
    # Convert r_surf to cartesian coordinates: x=0, y = r cos(φ), z = r sin(φ)
    r_surf_c = (0.0, r_surf[1] * cos(r_surf[2]), r_surf[1] * sin(r_surf[2]))
    r_det .+ r_surf_c .- r_src
end


function ω(u, p)   
    r, φ = u
    @show p
    dd = sqrt(sum(abs2, distance_source_surface(x_d, x_s, (r, φ))))
    cα = (x_d[1] - x_s[1]) / dd

    return/ dd^2
end

domain = ([-0.5 * d, 0], [0.5 * d, 2π])
prob = IntegralProblem(ω, domain, p=[2.0])
sol = solve(prob, HCubatureJL(); reltol=1e-3, abstol=1e-3)
sol.u

Output is

[...]

p = SciMLBase.NullParameters()
p = SciMLBase.NullParameters()
retcode: Success
u: 4.2620330863401925

4.2620330863401925

I would have expected that the integrand receives the parameter vector p.

Environment (please complete the following information):

  • Output of using Pkg; Pkg.status()
julia> Pkg.status()
Project inverse_test v0.1.0
Status `~/julia_envs/inverse_test/Project.toml`
  [c7e460c6] ArgParse v1.2.0
⌃ [13f3f980] CairoMakie v0.12.5
  [a93c6f00] DataFrames v1.6.1
⌃ [31c24e10] Distributions v0.25.109
  [5789e2e9] FileIO v1.16.3
⌃ [587475ba] Flux v0.14.16
  [de52edbc] Integrals v4.4.1
  [b7115f24] InvertibleNetworks v2.2.9
⌃ [033835bb] JLD2 v0.4.50
  [5ab0869b] KernelDensity v0.6.9
⌅ [ee78f7c6] Makie v0.21.5
⌅ [20f20a25] MakieCore v0.8.4
  [429524aa] Optim v1.9.4
  [2913bbd2] StatsBase v0.34.3
⌃ [fce5fe82] Turing v0.33.2
  [ddb6d928] YAML v0.4.12
Info Packages marked with ⌃ and ⌅ have new versions available. Those with ⌃ may be upgradable, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use `status --outdated`
  • Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
⌃ [47edcb42] ADTypes v1.6.2
  [621f4979] AbstractFFTs v1.5.0
  [80f14c24] AbstractMCMC v5.2.0
  [7f219486] AbstractNFFTs v0.8.2
  [7a57a42e] AbstractPPL v0.8.4
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.37
  [79e6a3ab] Adapt v4.0.4
  [35492f91] AdaptivePredicates v1.1.1
  [0bf59076] AdvancedHMC v0.6.1
  [5b7e9947] AdvancedMH v0.8.2
  [576499cb] AdvancedPS v0.6.0
  [b5ca4192] AdvancedVI v0.2.6
  [66dad0bd] AliasTables v1.1.3
  [27a7e980] Animations v0.4.1
  [dce04be8] ArgCheck v2.3.0
  [c7e460c6] ArgParse v1.2.0
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.15.0
  [a9b6321e] Atomix v0.1.0
  [67c07d97] Automa v1.0.4
  [13072b0f] AxisAlgorithms v1.1.0
  [39de3d68] AxisArrays v0.4.7
  [ab4f0b2a] BFloat16s v0.5.0
  [198e06fe] BangBang v0.4.3
  [9718e550] Baselet v0.1.1
  [26cce99e] BasicInterpolators v0.7.1
  [e2ed5e7c] Bijections v0.1.7
⌃ [76274a88] Bijectors v0.13.16
  [fa961155] CEnum v0.5.0
  [052768ef] CUDA v5.4.3
  [1af6417a] CUDA_Runtime_Discovery v0.3.4
⌃ [159f3aea] Cairo v1.0.5
⌃ [13f3f980] CairoMakie v0.12.5
  [49dc2e85] Calculus v0.5.1
  [082447d4] ChainRules v1.69.0
  [d360d2e6] ChainRulesCore v1.24.0
⌃ [9e997f8a] ChangesOfVariables v0.1.8
  [a2cac450] ColorBrewer v0.4.0
  [35d6a980] ColorSchemes v3.26.0
  [3da002f7] ColorTypes v0.11.5
  [c3611d14] ColorVectorSpace v0.10.0
  [5ae59095] Colors v0.12.11
  [861a8166] Combinatorics v1.0.2
  [38540f10] CommonSolve v0.2.4
⌃ [bbf7d656] CommonSubexpressions v0.3.0
  [f70d9fcc] CommonWorldInvalidations v1.0.0
⌃ [34da2185] Compat v4.15.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [8f4d0f93] Conda v1.10.2
  [88cd18e8] ConsoleProgressMonitor v0.1.2
⌃ [187b0558] ConstructionBase v1.5.6
  [6add18c4] ContextVariablesX v0.1.3
  [d38c429a] Contour v0.6.3
  [a8cc5b0e] Crayons v4.1.1
  [717857b8] DSP v0.7.9
  [9a962f9c] DataAPI v1.16.0
  [a93c6f00] DataFrames v1.6.1
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [244e2a9f] DefineSingletons v0.1.2
  [927a84f5] DelaunayTriangulation v1.1.3
  [8bb1440f] DelimitedFiles v1.9.1
  [b429d917] DensityInterface v0.4.0
  [85a47980] Dictionaries v0.4.2
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [aaf54ef3] DistributedArrays v0.6.7
⌃ [31c24e10] Distributions v0.25.109
  [ced4e74d] DistributionsAD v0.6.55
  [ffbed154] DocStringExtensions v0.9.3
  [5b8099bc] DomainSets v0.7.14
  [fa6b7ba4] DualNumbers v0.6.8
⌃ [366bfd00] DynamicPPL v0.28.2
⌅ [7c1d4256] DynamicPolynomials v0.5.7
  [b7d42ee7] Einsum v0.4.1
  [cad2338a] EllipticalSliceSampling v2.0.0
  [4e289a0a] EnumX v1.0.4
  [429591f6] ExactPredicates v2.2.8
  [e2ba6199] ExprTools v0.1.10
⌅ [6b7a57c9] Expronicon v0.8.5
  [411431e0] Extents v0.1.3
  [7a1cc6ca] FFTW v1.8.0
  [cc61a311] FLoops v0.2.2
  [b9860ae5] FLoopsBase v0.1.1
  [5789e2e9] FileIO v1.16.3
  [8fc22ac5] FilePaths v0.8.3
  [48062228] FilePathsBase v0.9.21
⌃ [1a297f60] FillArrays v1.11.0
⌃ [6a86dc24] FiniteDiff v2.23.1
  [53c48c17] FixedPointNumbers v0.8.5
⌃ [587475ba] Flux v0.14.16
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v0.10.36
  [b38be410] FreeType v4.1.1
  [663a7486] FreeTypeAbstraction v0.10.3
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.4.12
⌃ [0c68f7d7] GPUArrays v10.3.0
  [46192b85] GPUArraysCore v0.1.6
⌅ [61eb1bfa] GPUCompiler v0.26.7
  [cf35fbd7] GeoInterface v1.3.5
  [5c1252a2] GeometryBasics v0.4.11
  [a2bd30eb] Graphics v1.1.2
  [86223c79] Graphs v1.11.2
  [3955a311] GridLayoutBase v0.11.0
  [42e2da0e] Grisu v1.0.2
  [19dc6840] HCubature v1.6.0
  [1baab800] HybridArrays v0.4.16
⌃ [34004b35] HypergeometricFunctions v0.3.23
  [7869d1d1] IRTools v0.4.14
  [615f187c] IfElse v0.1.1
  [2803e5a7] ImageAxes v0.6.11
  [c817782e] ImageBase v0.1.7
  [a09fc81d] ImageCore v0.10.2
  [82e4d734] ImageIO v0.6.8
  [bc367c6b] ImageMetadata v0.9.9
  [313cdc1a] Indexing v1.1.1
  [9b13fd28] IndirectArrays v1.0.0
  [d25df0c9] Inflate v0.1.5
  [22cec73e] InitialValues v0.3.1
  [842dd82b] InlineStrings v1.4.2
  [505f98c9] InplaceOps v0.3.0
  [18e54dd8] IntegerMathUtils v0.1.2
  [de52edbc] Integrals v4.4.1
  [a98d9a8b] Interpolations v0.15.1
  [d1acc4aa] IntervalArithmetic v0.22.14
  [8197267c] IntervalSets v0.7.10
⌃ [3587e190] InverseFunctions v0.1.15
  [41ab1584] InvertedIndices v1.3.0
  [b7115f24] InvertibleNetworks v2.2.9
  [92d709cd] IrrationalConstants v0.2.2
  [f1662d9f] Isoband v0.1.1
  [c8e1da08] IterTools v1.10.0
  [42fd0dbc] IterativeSolvers v0.9.4
  [82899510] IteratorInterfaceExtensions v1.0.0
⌃ [033835bb] JLD2 v0.4.50
  [692b3bcd] JLLWrappers v1.5.0
  [bb331ad6] JOLI v0.8.5
  [682c06a0] JSON v0.21.4
  [b835a17e] JpegTurbo v0.1.5
  [b14d175d] JuliaVariables v0.2.4
⌃ [63c18a36] KernelAbstractions v0.9.22
  [5ab0869b] KernelDensity v0.6.9
  [2c470bb0] Kronecker v0.5.5
  [5be7bae1] LBFGSB v0.4.1
⌅ [929cbde3] LLVM v8.1.0
  [8b046642] LLVMLoopInfo v1.0.0
  [8ac3fa9e] LRUCache v1.6.1
  [b964fa9f] LaTeXStrings v1.3.1
  [2ee39098] LabelledArrays v1.16.0
  [984bce1d] LambertW v0.4.6
⌃ [23fbe1c1] Latexify v0.16.4
  [73f95e8e] LatticeRules v0.0.1
  [8cdb02fc] LazyModules v0.3.1
  [1d6d02ad] LeftChildRightSiblingTrees v0.2.0
  [6f1fad26] Libtask v0.8.7
  [d3d80556] LineSearches v7.3.0
  [7a12625a] LinearMaps v3.11.3
  [6fdf6af0] LogDensityProblems v2.1.1
⌃ [996a588d] LogDensityProblemsAD v1.9.0
  [2ab3a3ac] LogExpFunctions v0.3.28
  [e6f89c97] LoggingExtras v1.0.3
  [c7f686f2] MCMCChains v6.0.6
  [be115224] MCMCDiagnosticTools v0.3.10
  [e80e1ace] MLJModelInterface v1.11.0
  [d8e11817] MLStyle v0.4.17
  [f1d291b0] MLUtils v0.4.4
  [1914dd2f] MacroTools v0.5.13
⌅ [ee78f7c6] Makie v0.21.5
⌅ [20f20a25] MakieCore v0.8.4
  [af67fdf4] ManifoldDiff v0.3.10
  [1cead3c2] Manifolds v0.9.20
⌃ [3362f125] ManifoldsBase v0.15.12
  [dbb5928d] MappedArrays v0.4.2
  [0a4f8689] MathTeXEngine v0.6.1
  [99c1a7ee] MatrixEquations v2.4.2
  [c03570c3] Memoize v0.4.4
  [128add7d] MicroCollections v0.2.0
  [e1d29d7a] Missings v1.2.0
  [4886b29c] MonteCarloIntegration v0.2.0
  [e94cdb99] MosaicViews v0.3.4
  [102ac46a] MultivariatePolynomials v0.5.6
  [d8a4904e] MutableArithmetics v1.4.6
  [efe261a4] NFFT v0.13.5
  [d41bc354] NLSolversBase v7.8.3
⌃ [872c559c] NNlib v0.9.21
  [5da4648a] NVTX v0.3.4
  [77ba4419] NaNMath v1.0.2
  [71a1bf82] NameResolution v0.1.5
  [86f7a689] NamedArrays v0.10.3
  [356022a1] NamedDims v1.2.2
  [c020b1a1] NaturalSort v1.0.0
  [f09324ee] Netpbm v1.1.1
  [4d1e1d77] Nullables v1.0.0
  [510215fc] Observables v0.5.5
  [6fe1bfb0] OffsetArrays v1.14.1
  [0b1bfda6] OneHotArrays v0.2.5
  [52e1d378] OpenEXR v0.3.2
  [429524aa] Optim v1.9.4
  [3bd65402] Optimisers v0.3.3
  [7f7a1694] Optimization v3.27.0
⌃ [bca83a33] OptimizationBase v1.3.3
  [36348300] OptimizationOptimJL v0.3.2
  [bac558e1] OrderedCollections v1.6.3
  [90014a1f] PDMats v0.11.31
  [f57f5aa1] PNGFiles v0.4.3
  [19eb6ba3] Packing v0.5.0
  [5432bcbf] PaddedViews v0.5.12
  [d96e819e] Parameters v0.12.3
  [69de0a69] Parsers v2.8.1
  [eebad327] PkgVersion v0.3.3
  [995b91a9] PlotUtils v1.4.1
  [647866c9] PolygonOps v0.1.2
  [f27b6e38] Polynomials v4.0.11
  [2dfb63ee] PooledArrays v1.4.3
  [85a6dd25] PositiveFactorizations v0.2.4
⌃ [d236fae5] PreallocationTools v0.4.23
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [8162dcfd] PrettyPrint v0.2.0
  [08abe8d2] PrettyTables v2.3.2
  [27ebfcd6] Primes v0.5.6
  [33c8b6b6] ProgressLogging v0.1.4
  [92933f4c] ProgressMeter v1.10.2
  [43287f4e] PtrArrays v1.2.0
  [438e738f] PyCall v1.96.4
  [4b34888f] QOI v1.0.0
  [1fd47b50] QuadGK v2.10.1
  [8a4e6c94] QuasiMonteCarlo v0.3.3
  [94ee1d12] Quaternions v0.7.6
  [74087812] Random123 v1.7.0
⌃ [e6cf234a] RandomNumbers v1.5.3
  [b3c3ace0] RangeArrays v0.3.2
  [c84ed2f1] Ratios v0.4.5
  [c1ae055f] RealDot v0.1.0
  [3cdcf5f2] RecipesBase v1.3.4
⌃ [731186ca] RecursiveArrayTools v3.26.0
  [189a3867] Reexport v1.2.2
  [05181044] RelocatableFolders v1.0.1
  [ae029012] Requires v1.3.0
  [79098fc4] Rmath v0.7.1
  [f2b01f46] Roots v2.1.6
  [5eaf0fd0] RoundingEmulator v0.2.1
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [fdea26ae] SIMD v3.5.0
⌅ [26aad666] SSMProblems v0.1.1
⌃ [0bca4576] SciMLBase v2.48.1
⌃ [c0aeaf25] SciMLOperators v0.3.8
  [53ae85a6] SciMLStructures v1.4.2
  [30f210dd] ScientificTypesBase v3.0.0
  [6c6a2e73] Scratch v1.2.1
  [91c51154] SentinelArrays v1.4.5
  [efcf1570] Setfield v1.1.1
  [65257c39] ShaderAbstractions v0.4.1
  [605ecd9f] ShowCases v0.1.0
  [992d4aef] Showoff v1.0.3
  [73760f76] SignedDistanceFields v0.4.0
  [699a6c99] SimpleTraits v0.9.4
  [ce78b400] SimpleUnPack v1.1.0
  [47aef6b3] SimpleWeightedGraphs v1.4.0
  [45858cf5] Sixel v0.1.3
  [ed01d8cd] Sobol v1.5.0
  [a2af1166] SortingAlgorithms v1.2.1
  [dc90abb0] SparseInverseSubset v0.1.2
  [276daf66] SpecialFunctions v2.4.0
  [171d559e] SplittablesBase v0.1.15
  [cae243ae] StackViews v0.1.1
  [90137ffa] StaticArrays v1.9.7
  [1e83bf80] StaticArraysCore v1.4.3
  [64bff920] StatisticalTraits v3.4.0
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.1
  [69024149] StringEncodings v0.3.7
  [892a3eda] StringManipulation v0.3.4
  [09ab397b] StructArrays v0.6.18
⌅ [4297ee4d] SymbolicAnalysis v0.1.0
⌃ [2efcf032] SymbolicIndexingInterface v0.3.27
⌃ [19f23fe9] SymbolicLimits v0.2.1
⌅ [d1185830] SymbolicUtils v2.1.2
⌅ [0c5d862f] Symbolics v5.35.1
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.12.0
  [62fd8b95] TensorCore v0.1.1
⌅ [8ea1fca8] TermInterface v0.4.1
  [5d786b92] TerminalLoggers v0.1.7
  [b718987f] TextWrap v1.0.2
  [731e570b] TiffImages v0.10.0
  [a759f4b9] TimerOutputs v0.5.24
  [9f7883ad] Tracker v0.2.34
⌃ [3bb67fe8] TranscodingStreams v0.11.1
  [28d57a85] Transducers v0.4.82
  [981d1d27] TriplotBase v0.1.0
⌃ [fce5fe82] Turing v0.33.2
  [3a884ed6] UnPack v1.0.2
  [1cfade01] UnicodeFun v0.4.1
  [1986cc42] Unitful v1.21.0
  [a7c27f48] Unityper v0.1.6
  [013be700] UnsafeAtomics v0.2.1
⌅ [d80eeb9a] UnsafeAtomicsLLVM v0.1.5
  [81def892] VersionParsing v1.3.0
⌅ [29a6e085] Wavelets v0.9.5
  [efce3f68] WoodburyMatrices v1.0.0
  [ddb6d928] YAML v0.4.12
  [e88e6eb3] Zygote v0.6.70
  [700de1a5] ZygoteRules v0.2.5
  [02a925ec] cuDNN v1.3.2
  [6e34b625] Bzip2_jll v1.0.8+1
  [4e9b3aee] CRlibm_jll v1.0.1+0
⌅ [4ee394cb] CUDA_Driver_jll v0.9.2+0
⌅ [76a88914] CUDA_Runtime_jll v0.14.1+0
⌅ [62b44479] CUDNN_jll v9.0.0+1
  [83423d85] Cairo_jll v1.18.0+2
  [5ae413db] EarCut_jll v2.2.4+0
  [2e619515] Expat_jll v2.6.2+0
  [b22a6f82] FFMPEG_jll v6.1.1+0
  [f5851436] FFTW_jll v3.3.10+0
  [a3f928ae] Fontconfig_jll v2.13.96+0
  [d7e528f0] FreeType2_jll v2.13.2+0
  [559328eb] FriBidi_jll v1.0.14+0
  [78b55507] Gettext_jll v0.21.0+0
  [7746bdde] Glib_jll v2.80.2+0
  [3b182d85] Graphite2_jll v1.3.14+0
  [2e76f6c2] HarfBuzz_jll v2.8.1+1
  [905a6f67] Imath_jll v3.1.11+0
  [1d5cc7b8] IntelOpenMP_jll v2024.2.0+0
  [aacddb02] JpegTurbo_jll v3.0.3+0
  [9c1d0b0a] JuliaNVTXCallbacks_jll v0.2.1+0
  [c1c5ebd0] LAME_jll v3.100.2+0
⌅ [dad2f222] LLVMExtra_jll v0.0.31+0
⌃ [1d63c593] LLVMOpenMP_jll v15.0.7+0
  [dd4b983a] LZO_jll v2.10.2+0
  [81d17ec3] L_BFGS_B_jll v3.0.1+0
⌅ [e9f186c6] Libffi_jll v3.2.2+1
  [d4300ac3] Libgcrypt_jll v1.8.11+0
  [7add5ba3] Libgpg_error_jll v1.49.0+0
  [94ce4f54] Libiconv_jll v1.17.0+0
  [4b2f31a3] Libmount_jll v2.40.1+0
  [38a345b3] Libuuid_jll v2.40.1+0
  [856f044c] MKL_jll v2024.2.0+0
  [e98f9f5b] NVTX_jll v3.1.0+2
  [e7412a2a] Ogg_jll v1.3.5+1
  [18a262bb] OpenEXR_jll v3.2.4+0
  [458c3c95] OpenSSL_jll v3.0.14+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [91d4177d] Opus_jll v1.3.2+0
⌃ [36c8627f] Pango_jll v1.52.2+0
  [30392449] Pixman_jll v0.43.4+0
⌅ [f50d1b31] Rmath_jll v0.4.2+0
⌃ [02c8fc9c] XML2_jll v2.13.1+0
  [aed1982a] XSLT_jll v1.1.41+0
  [4f6342f7] Xorg_libX11_jll v1.8.6+0
  [0c0b7dd1] Xorg_libXau_jll v1.0.11+0
  [a3789734] Xorg_libXdmcp_jll v1.1.4+0
  [1082639a] Xorg_libXext_jll v1.3.6+0
  [ea2f1a96] Xorg_libXrender_jll v0.9.11+0
  [14d82f49] Xorg_libpthread_stubs_jll v0.1.1+0
  [c7cfdc94] Xorg_libxcb_jll v1.17.0+0
  [c5fb5394] Xorg_xtrans_jll v1.5.0+0
  [9a68df92] isoband_jll v0.2.3+0
  [a4ae2306] libaom_jll v3.9.0+0
  [0ac62f75] libass_jll v0.15.1+0
  [f638f0a6] libfdk_aac_jll v2.0.2+0
  [b53b4c65] libpng_jll v1.6.43+1
  [075b6546] libsixel_jll v1.10.3+0
  [f27f6e37] libvorbis_jll v1.3.7+2
  [1317d2d5] oneTBB_jll v2021.12.0+0
  [1270edf5] x264_jll v2021.5.5+0
  [dfaa095f] x265_jll v3.5.0+0
  [0dad84c5] ArgTools v1.1.1
  [56f22d72] Artifacts
  [2a0f44e3] Base64
  [8bf52ea8] CRC32c
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [4af54fe1] LazyArtifacts
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.10.0
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization
  [1a1011a3] SharedArrays
  [6462fe0b] Sockets
  [2f01184e] SparseArrays v1.10.0
  [10745b16] Statistics v1.10.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode
  [e66e0078] CompilerSupportLibraries_jll v1.1.1+0
  [deac9b47] LibCURL_jll v8.4.0+0
  [e37daf67] LibGit2_jll v1.6.4+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.2+1
  [14a3606d] MozillaCACerts_jll v2023.1.10
  [4536629a] OpenBLAS_jll v0.3.23+4
  [05823500] OpenLibm_jll v0.8.1+2
  [efcefdf7] PCRE2_jll v10.42.0+1
  [bea87d4a] SuiteSparse_jll v7.2.1+1
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.8.0+1
  [8e850ede] nghttp2_jll v1.52.0+1
  [3f19e933] p7zip_jll v17.4.0+2
  • Output of versioninfo()
Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 104 × Intel(R) Xeon(R) Gold 5320 CPU @ 2.20GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, icelake-server)
Threads: 104 default, 0 interactive, 52 GC (on 104 virtual cores)
Environment:
  JULIA_PKG_USE_CLI_GIT = true
  LD_LIBRARY_PATH_modshare = /cm/shared/apps/slurm/current/lib64:1:/cm/shared/apps/slurm/current/lib64/slurm:1:/cm/shared/apps/openmpi4/gcc/4.1.2/lib:1:/cm/shared/apps/hdf5_18/1.8.21/lib:1
  LD_RUN_PATH_modshare = /cm/shared/apps/openmpi4/gcc/4.1.2/lib:1:/cm/shared/apps/hdf5_18/1.8.21/lib:1
  LD_RUN_PATH = /cm/shared/apps/openmpi4/gcc/4.1.2/lib:/cm/shared/apps/hdf5_18/1.8.21/lib
  LD_LIBRARY_PATH = /cm/shared/apps/openmpi4/gcc/4.1.2/lib:/cm/shared/apps/hdf5_18/1.8.21/lib:/cm/shared/apps/slurm/current/lib64/slurm:/cm/shared/apps/slurm/current/lib64:/home/rkube/local/lib:/home/rkube/software/adios2/lib
  JULIA_EDITOR = code
@rkube rkube added the bug Something isn't working label Aug 23, 2024
@ChrisRackauckas
Copy link
Member

prob = IntegralProblem(ω, domain, [2.0])

but we should catch that better

@lxvm
Copy link
Collaborator

lxvm commented Aug 29, 2024

The docs do have a line saying IntegralProblem(f::AbstractIntegralFunction,domain,p=NullParameters(); kwargs...), but in Julia defining a function with argument p=p0 before the semicolon means that p is an optional positional argument with default value p0. On the other hand, calling a function with an argument p=p1 passes a keyword argument p to the function with value p1, even without a semicolon. This is not an Integrals.jl bug, however we could try and make the documentation more clear by having separate "arguments" and "keywords" sections and/or changing the function signature to IntegralProblem(f::AbstractIntegralFunction,domain, [p=NullParameters()]; kwargs...) to try and make it more clear that p is an optional positional argument. What would be most helpful?

@lxvm
Copy link
Collaborator

lxvm commented Aug 29, 2024

Also, running this example on master will throw a keyword argument error message since a recent commit fixed #242

@ChrisRackauckas
Copy link
Member

Interesting. Didn't know there was a released missed. Just sent out 4.5

@lxvm
Copy link
Collaborator

lxvm commented Aug 30, 2024

Ok! That release also has some changes to infinity transformations that may affect users. We'll see if issues come up

@lxvm
Copy link
Collaborator

lxvm commented Sep 12, 2024

In v4.5 the MWE will error with a useful message:

ERROR: Unrecognized keyword arguments found.
The only allowed keyword arguments to `solve` are:
(:maxiters, :abstol, :reltol)
See https://docs.sciml.ai/Integrals/stable/basics/solve/ for more details.

Unrecognized keyword arguments: [:p]

@lxvm lxvm closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants