Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegralProblem keywords not passed to solvers #242

Closed
lxvm opened this issue Feb 29, 2024 · 0 comments · Fixed by #244
Closed

IntegralProblem keywords not passed to solvers #242

lxvm opened this issue Feb 29, 2024 · 0 comments · Fixed by #244
Labels
bug Something isn't working

Comments

@lxvm
Copy link
Collaborator

lxvm commented Feb 29, 2024

As reported on Discourse the documentation says that keywords passed to an IntegralProblem are passed onto the solvers, but I do not believe this is the case for any solver.

I think it would be straightforward to fix this, e.g. by merging prob.kwargs into kwargs in init (see below)

function SciMLBase.init(prob::IntegralProblem{iip},

I am raising this issue because I would like some input on how this is handled in other SciML packages before attempting a fix, since I see the same language in the documentation, e.g. in NonlinearSolve.jl, but would like to ask what is done consistently in the ecosystem.

@lxvm lxvm added the bug Something isn't working label Feb 29, 2024
ChrisRackauckas added a commit that referenced this issue Mar 3, 2024
Fix #242 : Pass IntegralProblem kwargs to solvers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant