Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardDiff directly on all non-C solvers #239

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

lxvm
Copy link
Collaborator

@lxvm lxvm commented Feb 18, 2024

This should fix one of the last problems in SciML/SciMLExpectations.jl#148

In this pr we ForwardDiff directly on all non-C solvers since there are fewer restrictions on integrand types

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ArnoStrouwen
Copy link
Member

ArnoStrouwen commented Feb 22, 2024

I can't find the missing link that the Documenter CI is complaining about?

@ChrisRackauckas
Copy link
Member

I just saw this in Symbolics too. @mortenpi is this a Documenter bug?

docs/src/basics/FAQ.md Outdated Show resolved Hide resolved
@ChrisRackauckas ChrisRackauckas merged commit 4593763 into SciML:master Feb 22, 2024
7 of 8 checks passed
@lxvm lxvm deleted the forward branch February 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants