Guess it's transposed?

SciML · Aug 9, 2023 · ffc0574 · ffc0574
1 parent 78158af
commit ffc0574
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/benchmarks/cudalu.jl b/benchmarks/cudalu.jl
@@ -21,7 +21,7 @@ end
 algs = [MKLLUFactorization(), CUDAOffloadFactorization()]
 res = [Float32[] for i in 1:length(algs)]
 
-ns = 200:400:20000
+ns = 200:400:10000
 for i in 1:length(ns)
     n = ns[i]
     @info "$n × $n"

diff --git a/ext/LinearSolveMKLExt.jl b/ext/LinearSolveMKLExt.jl
@@ -110,11 +110,11 @@ function SciMLBase.solve!(cache::LinearCache, alg::MKLLUFactorization;
     m, n = size(A, 1), size(A, 2)
     if m > n
         Bc = copy(cache.b)
-        getrs!('N', A.factors, A.ipiv, Bc; info)
+        getrs!('T', A.factors, A.ipiv, Bc; info)
         return copyto!(cache.u, 1, Bc, 1, n)
     else
         copyto!(cache.u, cache.b)
-        getrs!('N', A.factors, A.ipiv, cache.u; info)
+        getrs!('T', A.factors, A.ipiv, cache.u; info)
     end
 
     SciMLBase.build_linear_solution(alg, cache.u, nothing, cache)