Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiox solution handling for KrylovJL on subarrays #348

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

ChrisRackauckas
Copy link
Member

Fixes #347

Copy link

@ai-maintainer ai-maintainer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-Maintainer Review for PR - Fiox solution handling for KrylovJL on subarrays

Title and Description 👍

The Title and description are clear, concise and helpful The title and description of the pull request are clear and concise. They effectively communicate the purpose of the changes, which is to fix the solution handling for KrylovJL on subarrays. The description also provides a reference to the specific issue being addressed in LinearSolve.jl.

Scope of Changes 👍

The changes are narrowly focused The changes in this pull request are narrowly focused on a specific issue. The modifications are made to the `solve!` function of the `LinearCache` type in the `iterative_wrappers.jl` file. The changes involve copying the solution to the allocated output vector if it is not already there. This suggests that the author is addressing a specific problem related to solution handling for KrylovJL on subarrays.

Testing ⚠️

Testing methodology is not described The description does not provide information on how the changes were tested. It would be beneficial for the author to provide details on the testing methodology, such as any specific test cases used or the steps taken to verify the fix. This would help reviewers and maintainers understand the testing process and have confidence in the changes made.

Suggested Changes

  • Please provide information on how the changes were tested. This could include specific test cases used or the steps taken to verify the fix.

Reviewed with AI Maintainer

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #348 (6a2aac0) into main (5e0b0b1) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   75.23%   75.29%   +0.05%     
==========================================
  Files          17       17              
  Lines        1264     1267       +3     
==========================================
+ Hits          951      954       +3     
  Misses        313      313              
Files Changed Coverage Δ
src/iterative_wrappers.jl 72.78% <100.00%> (+0.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 1c90035 into main Jul 31, 2023
10 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-1 branch July 31, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KrylovJL solvers returning incorrect answer when u0 is a SubArray
1 participant