Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolating if one or more of the dimensions has length 1. #330

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Qfl3x
Copy link
Contributor

@Qfl3x Qfl3x commented Oct 12, 2023

#304

Still has a warning assertion in case all ivs have length 1. Otherwise it will build an interpolation object for the non-"singleton" ivs.

If the model is prompted to give the solution using the interpolator, it will silently ignore the missing ivs and only consider the ivs for which length is > 1.

Performance shouldn't be too big of an issue, though it would've been better to only do the singleton ivs lookup once.

It's all silent, so feel free to add warnings or let me know if you want warnings.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6c8b78d) 69.95% compared to head (9af715e) 85.81%.
Report is 13 commits behind head on master.

Files Patch % Lines
src/interface/solution/common.jl 20.00% 8 Missing ⚠️
src/interface/solution/solution_utils.jl 80.00% 1 Missing ⚠️
src/system_parsing/pde_system_transformation.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #330       +/-   ##
===========================================
+ Coverage   69.95%   85.81%   +15.85%     
===========================================
  Files          38       40        +2     
  Lines        1741     1769       +28     
===========================================
+ Hits         1218     1518      +300     
+ Misses        523      251      -272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xtalax
Copy link
Member

xtalax commented Nov 14, 2023

Hey, rebase and this should pass - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants