-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolating if one or more of the dimensions has length 1. #330
Open
Qfl3x
wants to merge
12
commits into
SciML:master
Choose a base branch
from
Qfl3x:interp_notime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
===========================================
+ Coverage 69.95% 85.81% +15.85%
===========================================
Files 38 40 +2
Lines 1741 1769 +28
===========================================
+ Hits 1218 1518 +300
+ Misses 523 251 -272 ☔ View full report in Codecov by Sentry. |
Hey, rebase and this should pass - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#304
Still has a warning assertion in case all ivs have length 1. Otherwise it will build an interpolation object for the non-"singleton" ivs.
If the model is prompted to give the solution using the interpolator, it will silently ignore the missing ivs and only consider the ivs for which length is > 1.
Performance shouldn't be too big of an issue, though it would've been better to only do the singleton ivs lookup once.
It's all silent, so feel free to add warnings or let me know if you want warnings.