Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document @mtkmodel and @connector #2227

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Document @mtkmodel and @connector #2227

merged 1 commit into from
Sep 11, 2023

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Aug 14, 2023 •
edited
Loading

Documents Model, @mtkmodel and @connector

@ven-k ven-k force-pushed the vkb/mtkmodel-docs branch 4 times, most recently from 9828f49 to fe7d99a Compare September 8, 2023 18:26
@ven-k ven-k marked this pull request as ready for review September 8, 2023 18:40
YingboMa
YingboMa reviewed Sep 8, 2023
View reviewed changes
src/systems/model_parsing.jl Outdated
@@ -364,6 +383,7 @@ function parse_extend!(exprs, ext, dict, body, kwargs)
vars = nothing
if Meta.isexpr(b, :(=))
vars = a
@info 379 typeof(vars.head)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved here

@ven-k ven-k requested a review from YingboMa September 9, 2023 16:43
YingboMa
YingboMa approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to also update the rest of the tutorials in MTK?

@YingboMa YingboMa merged commit 2f81ea6 into SciML:master Sep 11, 2023
29 of 33 checks passed
@ven-k
Copy link
Member Author

ven-k commented Sep 11, 2023

Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ven-k @YingboMa