Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sample with multiple implicit clocks #2748

Closed
wants to merge 7 commits into from
Closed

Conversation

YingboMa
Copy link
Member

Fix #2731

@baggepinnen
Copy link
Contributor

I added a partial test, but it fails with

julia> sol = solve(prob, Tsit5(); kwargshandle = KeywordArgSilent)
ERROR: UndefVarError: `r` not defined
Stacktrace:
  [1] (::Tuple{})(arg#5964805160111424296::Any, arg#16064127567989806372::Any, arg#16674255279130770513::Any, t::Any)
    @ ModelingToolkit ~/.julia/packages/SymbolicUtils/c0xQb/src/code.jl:375
  [2] macro expansion
    @ ~/.julia/dev/ModelingToolkit/src/systems/clock_inference.jl:473 [inlined]
  [3] macro expansion
    @ ~/.julia/packages/RuntimeGeneratedFunctions/M9ZX8/src/RuntimeGeneratedFunctions.jl:163 [inlined]
  [4] macro expansion
    @ ./none:0 [inlined]
  [5] generated_callfunc
    @ ./none:0 [inlined]
  [6] (::RuntimeGeneratedFunctions.RuntimeGeneratedFunction{…})(::OrdinaryDiffEq.ODEIntegrator{…}, ::SavedValues{…})
    @ RuntimeGeneratedFunctions ~/.julia/packages/RuntimeGeneratedFunctions/M9ZX8/src/RuntimeGeneratedFunctions.jl:150
  [7] DiscreteSaveAffect
    @ ~/.julia/dev/ModelingToolkit/src/systems/diffeqs/abstractodesystem.jl:1074 [inlined]

@YingboMa
Copy link
Member Author

YingboMa commented Jun 6, 2024

@AayushSabharwal is the ModelingToolkitStandardLibrary test failure unrelated?

@YingboMa YingboMa closed this Jun 14, 2024
@YingboMa YingboMa deleted the myb/multiclock branch June 14, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to infer clock with variable appearing in multiple partitions
2 participants