Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SymbolicUtils 1.7.0 and 1.7.1 in MTK v8 #2975

Closed
wants to merge 1 commit into from

Conversation

devmotion
Copy link
Member

This PR adds support for SymbolicUtils 1.7.1 for MTK v8 in a backport to make the bugfix for the ConstructionBase/SymbolicUtils issue available for people stuck on MTK v8. Compatibility with SymbolicUtils was previously limited to <= 1.5.1 due to an incompatibility in 1.6.0 which was later reverted in 1.7.0: #2726

@devmotion devmotion marked this pull request as draft August 19, 2024 12:35
@devmotion
Copy link
Member Author

devmotion commented Aug 19, 2024

Is it clear why tests are failing? MTK v8.76.0 + SymbolicUtils v1.5.1 works fine for us, so maybe it's some other dependency that's causing tests to fail. v1.7.0 should be almost the same as v1.5.1, with the problematic changes reverted: JuliaSymbolics/SymbolicUtils.jl@v1.5.1...v1.7.0

Edit: SciMLBase downstream tests seem to pass.

@devmotion devmotion marked this pull request as ready for review August 19, 2024 12:41
@ChrisRackauckas
Copy link
Member

It's not obvious to me.

@devmotion
Copy link
Member Author

I started a CI run on the latest v8 release in #2976, to check if the test errors show up there as well.

@devmotion
Copy link
Member Author

In #2976 (latest release of MTK v8 + SymbolicUtils 1.5.1) the same errors are thrown, so it seems the update of some other dependency might have broken something. I guess this means the PR is fine and it's OK to make another release of MTK v8 with the bugfix for ConstructionBase 1.5.7 since it will be strictly superior to the existing release?

@ChrisRackauckas
Copy link
Member

Yes I'd accept it. That's a pretty bad looking error on v8 though, I'd try restricting SymbolicUtils.jl or Symbolics.jl and see if you can get it to pass.

@devmotion devmotion closed this Aug 28, 2024
@devmotion devmotion deleted the devmotion-patch-2 branch August 28, 2024 11:53
@devmotion
Copy link
Member Author

This is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants