Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FIRK solvers #2286

Merged
merged 49 commits into from
Jul 26, 2024
Merged

Added FIRK solvers #2286

merged 49 commits into from
Jul 26, 2024

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
solves a part of #2177

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas In this PR all the UnDef errors have been solved. This now has some precision and method call errors in some files

@ParamThakkar123
Copy link
Contributor Author

I have also started a PR for DAE solvers #2292

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas any changes or fixes needed on this PR ??

@ChrisRackauckas
Copy link
Member

Tests don't pass. The PredictiveController should not have been moved. Move that back, and then the spot that does if radau should be if isfirk(alg), and then in the alg_utils you should define isfirk(alg) = false, and then in the OrdinaryDiffEqFIRK/alg_utils.jl add isfirk(alg:: radau algorithms) = true.

@ChrisRackauckas ChrisRackauckas merged commit 4fd5afb into SciML:master Jul 26, 2024
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants