fix out of place WOperator
#2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jul 22, 2024
oscardssmith
force-pushed
the
os/fix-OOP-WOperator
branch
from
9a99596
to
a5f0be8
Compare
oscardssmith
force-pushed
the
os/fix-OOP-WOperator
branch
from
0239364
to
0772416
Compare
|
SciML/StochasticDiffEq.jl#574 fixes the StochasticDiffEq test failure (which was caused by testing that you can call calc_W! on an out of place ODE which you just can't do). The other test failures look unrelated. I think this is finally ready to merge. |
| @@ -908,42 +873,36 @@ function build_J_W(alg, u, uprev, p, t, dt, f::F, ::Type{uEltypeNoUnits}, | |||
| else | |||
| deepcopy(f.jac_prototype) | |||
| end | |||
| __f = if IIP | |||
| (du, u, p, t) -> _f(du, u, p, t) | |||
| W = if J isa StaticMatrix && alg isa OrdinaryDiffEqRosenbrockAdaptiveAlgorithm | |||
There was a problem hiding this comment.
why is this Rosenbrock specific?
There was a problem hiding this comment.
not sure. I was vaguely following how this worked previously
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2252 made it so there were some cases in which we weren't updating J correctly leading to convergence failures. Debugging this was hell, and all of this code needs to be ripped out in the nearish future and replaced with DifferentiationInterface and a sane layout. While I was at it, I also fixed a couple places where the stats were completely broken for out of place. Tests incoming.