Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate IIP information in the Wrapper Functions #543

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

avik-pal
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ece1966) 41.71% compared to head (d7f5284) 29.06%.

Files Patch % Lines
src/function_wrappers.jl 40.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #543       +/-   ##
===========================================
- Coverage   41.71%   29.06%   -12.65%     
===========================================
  Files          53       53               
  Lines        4123     4142       +19     
===========================================
- Hits         1720     1204      -516     
- Misses       2403     2938      +535     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Member Author

Sundials failure I checked locally goes away with this PR + JuliaDiff/SparseDiffTools.jl#275

@ChrisRackauckas ChrisRackauckas merged commit f6b059c into master Nov 17, 2023
33 of 39 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/propagate_iip branch November 17, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants