[WIP] Fix Ensemble indexing when output_func
is used
#607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
output_func
is used, the resulting type insim.u[i]
is no longer <:AbstractVectorOfArray
, so we need to avoid assuming that like in #599, #602 and #604I was thinking of the following output functions as tests:
For the plot recipes I was thinking that we could test if no warnings are thrown by the
plot
calls. That should catch depwarns too and if there's any error in the recipes, the test would error.This PR is WIP and not yet ready.