Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation for stripped solutions #790

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jClugstor
Copy link
Contributor

Checklist

  • [x ] Appropriate tests were added
  • [x ] Any code changes were done in a way that does not break public API
  • [x ] All documentation related to code changes were updated
  • [x ] The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • [x ] Any new documentation only uses public API

Additional context

Fixes interpolation for stripped solution objects, i.e. solution objects from strip_solution.

I'm not sure about doing struct ODENullFunction <: SciMLBase.AbstractODEFunction{false} end, but the inner constructor for ODEProblem doesn't allow f to be nothing. And the alternative seems to be changing the functors for ODEProblem. This also allows for stripped_solutions to keep some problem information. It might be good to add taking out the whole problem as an option as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant