Fix MatrixOperator concretize!

SciML · Jul 21, 2023 · 958e00a · 958e00a
1 parent 1fb11e2
commit 958e00a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/interface.jl b/src/interface.jl
@@ -321,7 +321,7 @@ function concretize!(A, L::AbstractMatrix, α, β)
 end
 
 function concretize!(A, L::Union{Factorization, AbstractSciMLOperator}, α, β) 
-    @warn """using concretize-based fallback for concretize!"""
+    @warn """using concretize-based fallback for concretize! for $(typeof(L))"""
     # TODO: could also use a mul! based fallback on the unit vectors
     concretize!(A, concretize(L), α, β)
 end

diff --git a/src/matrix.jl b/src/matrix.jl
@@ -159,8 +159,8 @@ function update_coefficients!(L::MatrixOperator, u, p, t; kwargs...)
     L.update_func!(L.A, u, p, t; kwargs...)
 end
 
-function concretize!(A, L::MatrixOperator)
-    return concretize!(A, L.A)
+function concretize!(A, L::MatrixOperator, α, β)
+    return concretize!(A, L.A, α, β)
 end
 
 SparseArrays.sparse(L::MatrixOperator) = sparse(L.A)

diff --git a/test/basic.jl b/test/basic.jl
@@ -333,7 +333,9 @@ end
     C = ConcretizedOperator(L)
     v = rand(2)
     C * v ≈ L * v
+    @test C.A ≈ convert(AbstractMatrix, L)
     update_coefficients!(C, nothing, nothing, 2.0)
     C * v ≈ L * v
+    @test C.A ≈ convert(AbstractMatrix, L)
 end
 #