avoid range allocation in SROCK step #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes SciML#478 note there is still 2 similar lines for the constant cached versions, which don't use inplace assignment. I don't know if the change is necessary there too.
Comment on lines
336
to
338
| rand!(W.rng, vec_χ) | ||
| else | ||
| rand!(vec_χ) |
There was a problem hiding this comment.
for the noise wrapper it should just forward it to W.W.rng
There was a problem hiding this comment.
I guess its W.source.rng
This reverts commit de61047. Is handled in its own
devmotion
reviewed
Sep 30, 2022
compute abs_dt outside broadcast reuse dwrange instead of creating new range Co-authored-by: David Widmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #478
note there is still 2 similar lines for the constant cached versions, which don't use inplace assignment. I don't know if the change is necessary there too.