-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AttributeError: 'GeoAxesSubplot' object has no attribute '_hold' #1120
Comments
So, I see the function says:
This issue was apparently fixed in matplotlib 1.2.x...so considering we only support matplotlib >=1.5, should we just nuke this function and be done? It would seem this should probably push us to get 0.17 out the door ASAP with whatever we have done. |
@zssherman Can you try monkey patching for me and see if it fixes PyART? from matplotlib.axes import Axes
from cartopy.mpl.geoaxes import GeoAxes
GeoAxes._pcolormesh_patched = Axes.pcolormesh To be clear, I don't recommend this as anything you guys ship, but want to see if that's enough to fix it. |
@dopplershift Sounds good! I will do the change and see if it fixes it. Thanks for the suggestion! And yeah I'll take your recommendation and not ship that. |
I also think matplotlib will put |
@dopplershift Ah gotcha. And the monkey patch seems to work for radarmapdisplay_cartopy. I will submit a pull request to pyart for the mean time as a temporary fix. |
That docstring is outdated; other things are done in |
Description
Hello, when running Travis on our package https://travis-ci.org/ARM-DOE/pyart/jobs/432631010#L1645-L1675. I encountered the error in the traceback below.
Looking into it more, it seems that in matplotlib 3.0.0, axes attribute hold was removed.
https://matplotlib.org/api/api_changes.html#removals
In geoaxes.py, hold is used. Matplotlib 3.0.0.
https://github.com/SciTools/cartopy/blob/master/lib/cartopy/mpl/geoaxes.py#L1450-L1465
Code
https://github.com/SciTools/cartopy/blob/master/lib/cartopy/mpl/geoaxes.py#L1450-L1465
Traceback
Full environment definition
Operating system
Ubuntu 14.04.5 LTS
Cartopy version
conda list
The text was updated successfully, but these errors were encountered: