Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Add pyproject.toml defining build requirements. #1132

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 27, 2018

This follows the new PEP518 metadata to get Cython and NumPy installed prior to building.

Fixes #1112.
See also #1035.

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd like to have an additional sign off on something so core to infrastructure.

@dopplershift dopplershift added this to the 0.17 milestone Sep 27, 2018
@ajdawson ajdawson self-requested a review October 30, 2018 09:35
Copy link
Member

@ajdawson ajdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, provided that the source distribution is built using an up-to-date version of setuptools. If an older version is used (I tried 40.0.0) then the pyproject.toml file is not automatically included in the source distribution and has to be added to MANIFEST.in. I don't know if it is worth being explicit about this or not.

@QuLogic
Copy link
Member Author

QuLogic commented Oct 30, 2018

Hmm, might as well; I've added it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants