-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust setup.py
to reflect PEP-518, instead of throwing a "you need cython" error.
#1112
Comments
Technically, that's not adding PEP 518 support, just fixing the existing workaround so it works with For PEP 518 support, a new [build-system]
requires = ["Cython>=0.15.1", "numpy>=1.10", "setuptools", "wheel"] |
Great that this is finally solved! 😄 |
It's great that this is finally solved. But unfortunately it has also been un-solved later 😛 From the commit it seems this was because it results in some version mismatch in numpy coming from build dependencies vs numpy comping from actual dependency (although I am not completely sure what the exact reason is). I am not sure how cartopy's build works, and what solutions are there to prevent this, but can this possibly be solved with a slightly modern build tool like poetry/dephell? I know that is sort of significant change to the project, but if that sounds like a good idea maybe I can try and take a dig at this. Would love to know maintainers thoughts on this (maybe from @dopplershift, @pelson or @QuLogic probably?). |
Should this issue be ideally re-opened at least? |
Description
Fix
setup.py
to installcython
, instead of giving the user an error.pypa/pip#5761 (comment)
https://www.python.org/dev/peps/pep-0518/
Code to reproduce
On a fresh vitrual enviroment:
Traceback
Operating system
Ubuntu 16.04
The text was updated successfully, but these errors were encountered: