Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable installing with PROJ 6.0.0 #1289

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

snowman2
Copy link
Contributor

@snowman2 snowman2 commented Mar 28, 2019

Addresses #1288

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Mar 28, 2019
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@snowman2 snowman2 changed the title enabled installing with PROJ 6.0.0 enable installing with PROJ 6.0.0 Mar 28, 2019
@snowman2
Copy link
Contributor Author

Looks like it will actually install now. The test still fail, but I am not sure how you want to handle those.

setup.py Show resolved Hide resolved
@SciTools-assistant SciTools-assistant removed the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Mar 29, 2019
@snowman2
Copy link
Contributor Author

CLA signed.

@QuLogic
Copy link
Member

QuLogic commented May 18, 2019

It looks like this might need a bit more work to get tests to pass with proj6?

@snowman2
Copy link
Contributor Author

Correct, but the scope of this PR is simply to enable installing with PROJ >= 6.0.0.

The test results are different than previous versions due to updates in PROJ that I believe are more correct. The main question is: does cartopy want to have different expected test results based on the version? Or just to update the tests to the new version?

@dopplershift
Copy link
Contributor

😱

@whyboris
Copy link

whyboris commented Jun 10, 2019

Could we release this? I'm unable to install cartopy because

#error 'To use the proj_api.h you must define the macro ACCEPT_USE_OF_DEPRECATED_PROJ_API_H'

This happens while installing pyviz 😅

@dopplershift dopplershift added this to the 0.17.1 milestone Jun 13, 2019
@dopplershift
Copy link
Contributor

I don't have the cycles to push out a release right now, but I will be trying to get CartoPy to a next release at the SciPy sprints next month. Help getting PRs reviewed and finished welcome.

@djhoese
Copy link

djhoese commented Jun 26, 2019

I know @dopplershift said he'll be working on this at SciPy, but has anyone else put more work in to this? I have a tutorial at SciPy that would benefit from having the CRS objects from pyproj 2.0+ but as far as I know that requires PROJ 6.0+ and my tutorial uses cartopy.

@snowman2 @dopplershift What's left to do on this? Can I help? Or is most of the trouble in the time to create a release?

@snowman2
Copy link
Contributor Author

snowman2 commented Jun 26, 2019

@djhoese if this is not released by the time your tutorial happens, you could install the dependencies of cartopy with proj 6+ and do:

pip install git+https://github.com/snowman2/cartopy.git@5e624fe

@ocefpaf
Copy link
Member

ocefpaf commented Jun 26, 2019

@djhoese and @snowman2 that can be hard for the attendants due to the c extensions in cartopy. Maybe we can publish the "dev" release on a conda-forge dev label. Would that help?

@djhoese
Copy link

djhoese commented Jun 26, 2019

I suppose if it is easy enough to install, but attendees have already starting installing stuff by following my instructions so maybe it is better to just wait for a full release? I can live with the older versions of pyproj and just explain what's "coming down the pipeline" if I have to.

@dopplershift
Copy link
Contributor

@djhoese If it were my tutorial, I'd feel better about living with current releases, unless they're hopelessly broken. Can never be sure when volunteer-run projects will actually have enough the time to do a release.

@djhoese
Copy link

djhoese commented Jul 5, 2019

😉 @dopplershift Tell me about it. No problem. Thanks for all your work and status updates.

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's at least get this in so we can build against current things. We'll work on fixing the tests next.

@hnsywangxin
Copy link

you can try add ADD_DEFINITIONS(-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1) cmakelist.txt

@dopplershift
Copy link
Contributor

@hnsywangxin We don't use cmake to build, so I'm not sure how this is relevant? Also, this PR has already been merged, so I'm not sure that's adding anything.

@2sn
Copy link

2sn commented Mar 7, 2021

CFLAGS="-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H" pip3 install cartopy

@snowman2
Copy link
Contributor Author

snowman2 commented Mar 7, 2021

@2sn, these are open source projects. As such, you are welcome to contribute to improve them. That being said, pyproj 3.0.1 should work with PROJ 8. See: https://pyproj4.github.io/pyproj/stable/installation.html

@snowman2
Copy link
Contributor Author

snowman2 commented Mar 7, 2021

Changes needed to be compatible in #1140

@2sn
Copy link

2sn commented Mar 7, 2021

@snowman2 Found workaround, see above. May not be new. Installing on older OS, not all libraries may be up to date.
but, as I said, even installing from github

pip install git+https://github.com/snowman2/cartopy.git

does not fix the problems w/o the environment setting.

Thanks for your work on the project. Seems monumental task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants