-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable installing with PROJ 6.0.0 #1289
Conversation
Looks like it will actually install now. The test still fail, but I am not sure how you want to handle those. |
CLA signed. |
It looks like this might need a bit more work to get tests to pass with proj6? |
Correct, but the scope of this PR is simply to enable installing with PROJ >= 6.0.0. The test results are different than previous versions due to updates in PROJ that I believe are more correct. The main question is: does cartopy want to have different expected test results based on the version? Or just to update the tests to the new version? |
😱 |
Could we release this? I'm unable to install
This happens while installing |
I don't have the cycles to push out a release right now, but I will be trying to get CartoPy to a next release at the SciPy sprints next month. Help getting PRs reviewed and finished welcome. |
I know @dopplershift said he'll be working on this at SciPy, but has anyone else put more work in to this? I have a tutorial at SciPy that would benefit from having the CRS objects from pyproj 2.0+ but as far as I know that requires PROJ 6.0+ and my tutorial uses cartopy. @snowman2 @dopplershift What's left to do on this? Can I help? Or is most of the trouble in the time to create a release? |
@djhoese if this is not released by the time your tutorial happens, you could install the dependencies of cartopy with proj 6+ and do:
|
I suppose if it is easy enough to install, but attendees have already starting installing stuff by following my instructions so maybe it is better to just wait for a full release? I can live with the older versions of pyproj and just explain what's "coming down the pipeline" if I have to. |
@djhoese If it were my tutorial, I'd feel better about living with current releases, unless they're hopelessly broken. Can never be sure when volunteer-run projects will actually have enough the time to do a release. |
😉 @dopplershift Tell me about it. No problem. Thanks for all your work and status updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's at least get this in so we can build against current things. We'll work on fixing the tests next.
you can try add ADD_DEFINITIONS(-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1) cmakelist.txt |
@hnsywangxin We don't use cmake to build, so I'm not sure how this is relevant? Also, this PR has already been merged, so I'm not sure that's adding anything. |
CFLAGS="-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H" pip3 install cartopy |
@2sn, these are open source projects. As such, you are welcome to contribute to improve them. That being said, pyproj 3.0.1 should work with PROJ 8. See: https://pyproj4.github.io/pyproj/stable/installation.html |
Changes needed to be compatible in #1140 |
@snowman2 Found workaround, see above. May not be new. Installing on older OS, not all libraries may be up to date.
does not fix the problems w/o the environment setting. Thanks for your work on the project. Seems monumental task. |
Addresses #1288