-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: no quick transform, when there is no vertices #1380
Conversation
f5b2ca5
to
bed71b3
Compare
What is the error that this is fixing? You will need an editable install of Cartopy in order to run tests. |
It fixes the IndexError and allows to plot my data. I need to make a test yet for this.
At some point, I was able to run the tests, but now I have to remember how I did it. |
bed71b3
to
8dceb63
Compare
Sorry @rcomer, I can't find the test code... I should have posted it....(( I did rebased and pushed, not sure if you have a test for this problem though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1250,7 +1250,7 @@ def quick_vertices_transform(self, vertices, src_crs): | |||
if vertices.size == 0: | |||
return vertices | |||
|
|||
if self == src_crs: | |||
if self == src_crs and len(vertices) > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the lines 1250-1251, which were added at #2213, I don’t think this check will ever be exercised.
Rationale
The tricontourf fails with the dataset I have, because the
vertices
parameter inquick_vertices_transform
is empty.Implications
Checklist
If you have not already done so, ensure you've read and signed the Contributor Licence Agreement (CLA).
(See the governance page for the CLA and what to do with it).
Ensure there is a suitable item in the cartopy test suite for the change you are proposing.
I am not able to run the tests.