Switch to setuptools-scm instead of versioneer. #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
setuptools-scm
branch
2 times, most recently
from
4bf08e9
to
ce88307
Compare
|
Overall looks good to me and a positive to get rid of the forked versioneer code, but I'm not an expert on packaging at all. Do we need to pin setuptools_scm to a minimum version or anything like that to still work with Python 3.5 for now? |
|
I like the change. This is what I've switched to elsewhere. |
|
Well, CI passes, so I guess 3.5 should be fine? Anyway, if we do #1518, we won't have to worry about 3.5. |
dopplershift
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
I'd say go ahead and merge. If this is done @QuLogic go ahead and self-merge I'd say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Versioneer seems to break with PEP517 and newer packaging tools. The supported tool is setuptools-scm.
Implications
Better-working installs.