FIX: pcolor shading with nearest #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Oct 7, 2021
With wrapped coordinates and shading=nearest/auto, we are updating the points before passing into Matplotlib, so we also need to update the shading keyword before passing into matplotlib.
Gouraud shading doesn't work with pcolor() calls. However, we can at least attempt to get the shapes right so that an error isn't raised, but rather a warning indicating what the user should do.
greglucas
force-pushed
the
pcolor-shading-nearest
branch
from
edb4439
to
f3c9315
Compare
QuLogic
approved these changes
Oct 8, 2021
QuLogic
added a commit
to QuLogic/cartopy
that referenced
this pull request
Oct 8, 2021
FIX: pcolor shading with nearest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1889
The first commit is the one that closes the issue.
I then decided to expand it to try and hit all of the shading cases and looked at gouraud as well.
pcolordoes not handle gouraud shading, so the way we handle wrapped cells doesn't work all that well. However, currently it raises an error, so we can at least fix that and give a nice warning and continue on with an attempt at plotting masked cells.The third commit is a cleanup of some other shape mismatches in the tests.
I can break this out into separate PRs if that would be helpful, but I figured it was close enough.