Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Update test tolerances for MPL 3.5 #1938

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

greglucas
Copy link
Contributor

Matplotlib 3.5 caused some images to change slightly, so increase the tolerances on those tests since they were minor.

  • The three pcolormesh tests are all using the same image and looks to be very minor with a new tolerance update acceptable.

  • The multiple_projections_520 test appears to have had the entire axes stretched up (or down, I can't tell which image is which here) ever so slightly. So, the boundaries and line all are shifted a pixel or two in the new result image. A tolerance increase is probably acceptable again.

  • The contours is a little more troubling. It looks like the contours now follow the boundary to close on each other and get smeared on the far right edge, whereas that wasn't the case before. @QuLogic, I know you had to update some of the contour open/closed paths on the Matplotlib side, so perhaps you have some insight on this one.
    contour-result

Matplotlib 3.5 caused some images to change slightly, so increase
the tolerances on those tests since they were minor.
@dopplershift dopplershift added this to the 0.20.2 milestone Nov 16, 2021
@greglucas
Copy link
Contributor Author

Do not merge yet, I pushed this up to see if CI was able to run with 3.5 yet or not. (Apparently the answer is no)

@dopplershift
Copy link
Contributor

Yeah, I'm currently working on getting matplotlib 3.5 builds on conda-forge (just waiting on some new fonttools packages across the architectures since matplotlib added that dependency). Then I'll work on getting the testing builds for 3.5 up.

This update the contour test limits due to changed contouring with
closed paths in Matplotlib 3.5.

Additionally updates the Continuous Integration package to make
sure we get proj>=8 and add color to the output.
@greglucas
Copy link
Contributor Author

OK, I think the failures now are due to conda inconsistencies with packages. Specifically having to do with installing the unicodedata2 package. The unicode \N{} is correct here and works fine normally, so that package is just my guess as to the failure.

Don't run on forks of the repo.
@dopplershift
Copy link
Contributor

dopplershift commented Nov 24, 2021

@greglucas It turns out to be an old bug in charset_normalizer, and right now conda-forge's requests 2.26.0 package is pinning down a bugged version. This should be resolved as soon as my PR lands on conda-forge's recipe.

@greglucas
Copy link
Contributor Author

Thanks for looking into that @dopplershift! It looks like that did it :)

@dopplershift dopplershift merged commit 0f60502 into SciTools:master Nov 24, 2021
@greglucas greglucas deleted the mpl-35-test-tolerances branch November 28, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants