DEPR: implement API changes that were scheduled for cartopy>0.18 #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
cartopy 0.20 still emits some deprecation warnings about api changes that were supposed to happen after 0.18
Possibly I'm just reading the warning wrong but I'm assuming this was simply forgotten for a short while so I'm proposing this patch to live up to the promised change.
Implications
Checklist
If you have not already done so, ensure you've read and signed the Contributor Licence Agreement (CLA).
(See the governance page for the CLA and what to do with it).
If this is a new feature, please provide an example of its use in the description. We may want to make a
follow-on pull request to put the example in the gallery!
Ensure there is a suitable item in the cartopy test suite for the change you are proposing.
(disclosure: I'm assuming this change is sufficiently tested already)