FIX: Calculate bbox for pcolormesh #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Dec 7, 2021
|
I have no idea on that failure... Looks like the geos libraries are struggling with linking, so it could be something related to the shapely/cartopy geos library imports got mixed up somewhere along the line in a recent conda build of shapely or geos... |
|
Well, a rebuild made it worse... Seems like one of the shapefiles was updated and now the result is a bit different, so all builds fail. The original failure is still broken too. |
This was missed in the pcolormesh refactor causing some incorrect bounds calculations when plotting the data.
greglucas
force-pushed
the
pcolormesh-bbox
branch
from
009ed75
to
3d82245
Compare
dopplershift
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in the pcolormesh refactor causing some incorrect bounds calculations when plotting the data. It was typically covered up by the pcolor wrapped addition updating the limits there, so it wasn't caught earlier.
Commit: 00400f3
PR: #1646
Added some tests to try and check these data limits in the future.
Fixes #1947