FIX: Add clip limits to Nightshade floating point calculations #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the values input to Nightshade, the floating point precision could put the range for arccos outside of [-1, 1], which in turn numpy returns as nan's, yielding bad geometries further downstream. This patch clips the arccos calculations to [-1, 1] to guarantee we aren't out of the valid floating point bounds.
greglucas
force-pushed
the
nightshade-fp
branch
from
f43ae9e
to
f1de1e0
Compare
dopplershift
approved these changes
Jan 21, 2022
|
Yes, it seems unrelated as there is no NightShade being used in that example. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the values input to Nightshade, the floating point
precision could put the range for arccos outside of [-1, 1], which
in turn numpy returns as nan's, yielding bad geometries further
downstream. This patch clips the arccos calculations to [-1, 1] to
guarantee we aren't out of the valid floating point bounds.
Fixes #1988