Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 updating #1991

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Flake8 updating #1991

merged 3 commits into from
Jan 29, 2022

Conversation

greglucas
Copy link
Contributor

Removing all of the flake8 ignores and updating the code appropriately.

All of the math still looks reasonable to me.

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; some slight cleanup can be done:

lib/cartopy/io/srtm.py Outdated Show resolved Hide resolved
lib/cartopy/io/srtm.py Outdated Show resolved Hide resolved
lib/cartopy/tests/mpl/test_gridliner.py Outdated Show resolved Hide resolved
lib/cartopy/tests/mpl/test_images.py Outdated Show resolved Hide resolved
lib/cartopy/tests/mpl/test_images.py Outdated Show resolved Hide resolved
lib/cartopy/tests/test_util.py Outdated Show resolved Hide resolved
lib/cartopy/tests/test_util.py Show resolved Hide resolved
lib/cartopy/tests/test_util.py Outdated Show resolved Hide resolved
@greglucas
Copy link
Contributor Author

Thanks got those and added a few more from the test_utils.

@greglucas greglucas merged commit 22cdafc into SciTools:main Jan 29, 2022
@greglucas greglucas deleted the flake8-updating branch January 29, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants