FIX: setup.py should output "... 8.0.0 *or later*" if proj is missing or too old #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jan 22, 2022
setup.py
Outdated
| 'Proj version %s is installed, but cartopy requires at least ' | ||
| 'version %s.' % ('.'.join(str(v) for v in proj_version), | ||
| '.'.join(str(v) for v in PROJ_MIN_VERSION)), | ||
| f'Proj version {proj_version_string} is installed, but cartopy requires ' |
There was a problem hiding this comment.
E501 line too long (85 > 79 characters)
There was a problem hiding this comment.
sorry, fixed in 2nd commit
SciTools-assistant
added
the
Blocked: CLA needed
weatherfrog
force-pushed
the
fix-setup.py-proj-version-error-messages
branch
from
f292219
to
5e9e0c4
Compare
|
One single test failed on "ubuntu-latest, 3.9". It seems unlikely that this has anything to do with the changes made to Anyone? |
|
That test should be fixed now. If you rebase and force-push here it should pick that up and pass. This seems fine, although I'm still hopeful we can get rid of the PROJ dependency altogether before the next release. |
greglucas
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When trying to install CartoPy with
projmissing, this is the error message you get:This is misleading since the docs say "PROJ 8.0.0 or later". Therefore, the error message should be updated accordingly.
Implications
No negative implications expected.