Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Ordnance Survey img_tile to new OS API #2105
Updated Ordnance Survey img_tile to new OS API #2105
Changes from 8 commits
647a3c5
56523cf
52a4b92
86175dd
576017f
64a7a0c
6925799
d4478a3
89376b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like they do still have the WMTS endpoint with query parameters if you want to use that still?
https://api.os.uk/maps/raster/v1/wmts?request=getcapabilities&key=
from: https://osdatahub.os.uk/docs/wmts/technicalSpecification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the WMTS endpoint is still available. I thought the zxy endpoint was a bit more concise, so I went with that instead. Do you think it'd be better to keep it as a WMTS endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greglucas just following up on this - would a WMTS be better than a ZXY endpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I don't think we need to at this point. If you or someone else wants more flexibility in the future that can be a follow-up PR.