Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with shapely 2.0 (remove usage of lgeos) #2110

Merged

Conversation

jorisvandenbossche
Copy link
Contributor

The changes of #2080 squashed and applied to v0.21.x branch

@jorisvandenbossche
Copy link
Contributor Author

@greglucas any idea if the CI failures are related?

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those test failures are unrelated. I am getting them locally as well. Looks like someone must have changed the XML content or parsing somewhere along the chain with those remote tests. We should really get that XML content and monkeypatch URL to not go to a remote resource when possible... But, lets not have that hold us up here.

Thanks, @jorisvandenbossche!

@greglucas greglucas merged commit f89f17c into SciTools:v0.21.x Dec 8, 2022
@jorisvandenbossche jorisvandenbossche deleted the compat-shapely-2-for-0.21 branch December 8, 2022 15:58
@greglucas
Copy link
Contributor

Actually, it looks like this wasn't enough. I just checked out shapely 2.0 with the Cartopy v0.21.x branch and there are a few failures still. I am not sure it is worth the effort of doing all the backporting on v0.21.x versus just making a new minor release from main.

@jorisvandenbossche
Copy link
Contributor Author

@greglucas which failure do you see? CI here has a build with shapely 2.0rc3, and AFAIK the only 2 failures are the unrelated ones that also happen in the other builds

@greglucas
Copy link
Contributor

Uggh, I must have been looking at other Actions and didn't realize this did bring the CI over as well, sorry for the noise! I created a new environment locally and now all is working as expected (with the two unrelated tests failing).

I just pushed a release from this branch, so people should be able to use the new Cartopy and Shapely releases together now.

@jorisvandenbossche
Copy link
Contributor Author

Great! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants