Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove mentions of GDAL #2115

Merged
merged 1 commit into from
Dec 14, 2022
Merged

MNT: Remove mentions of GDAL #2115

merged 1 commit into from
Dec 14, 2022

Conversation

greglucas
Copy link
Contributor

It isn't used anywhere within Cartopy and can be handled by other libraries.

@greglucas greglucas added this to the 0.22 milestone Dec 13, 2022
@QuLogic QuLogic closed this Dec 14, 2022
@QuLogic QuLogic reopened this Dec 14, 2022
@QuLogic
Copy link
Member

QuLogic commented Dec 14, 2022

What about requirements/plotting.txt?

It isn't used anywhere within Cartopy and can be handled
by other libraries.
@greglucas
Copy link
Contributor Author

Oops, I had changed it, but forgot to save the file before committing. Thanks for catching that!

@dopplershift
Copy link
Contributor

I'm not finding any more with grep now.

@amotl
Copy link

amotl commented Feb 16, 2023

Dear Greg,

we appreciate the removal of the GDAL dependency from Cartopy very much. Because we are currently blocked at earthobservations/wetterdienst#878 and earthobservations/wetterdienst#879, it would be so lovely to rebase this work on top of a new Cartopy release, which will not pull in GDAL. Is there anything you could do about it? 🌻

With kind regards,
Andreas.

@greglucas
Copy link
Contributor Author

This PR should have been mostly a "documentation" change and not a code/requirement change. GDAL only comes in via pip install -r requirements/plotting.txt or through the environment.yaml, so my guess is that the GDAL dependency comes from somewhere else for you (Fiona?).

@amotl
Copy link

amotl commented Feb 16, 2023

Hi Greg,

thank you very much for clarifying. You are right, GDAL does not get pulled in by Cartopy, but by wradlib-1.18.0 instead, despite it is being listed as optional 1.

Sorry for the noise and with kind regards,
Andreas.

Footnotes

  1. https://github.com/wradlib/wradlib/blob/1.18.0/requirements_optional.txt#L3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants