allow multiple OGC_SRS synonyms for WebMaps #2138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Another fix I noticed related to WebMap services.
(@dopplershift I know it would have been better to already add this in #2136 but you were too fast in merging 😅 )
At the moment the identification of OGC_SRS identifiers is done via the
_CRS_TO_OGC_SRS
dict which is structured as follows:{projection : "EPSG----"}
This however creates a problem if multiple codes exist, which is especially true for the most commonly used WebMercator projection, e.g:
900913
(outdated but still sometimes used and at the moment the only hardcoded synonym forccrs.GOOGLE_MERCATOR
)3857
(the actual epsg code for the projection (see osm-wiki)This pull-request changes the definition for
_CRS_TO_OGC_SRS
to use lists (so that multiple synonyms can be provided), and implements the necessary changes in the functions that use_CRS_TO_OGC_SRS
.In addition the check is now done based on lower-case strings to avoid issues with WebMaps that use
epsg:---
instead ofEPSG:----
.Implications
EPSG:3857
now work as expected."epsg:----"
)