Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
pre-commit.ci
badge to theREADME.md
as a follow on to #1934Controversially, I've also removed the
autofix_prs
disable in the.pre-commit-config.yaml
- totally happy to encourage debate on this choice.Personally, the
pre-commit.ci
autofix does save the exact situation that we're initially in, where we banked a PR that wasn't compliant for all the git-hooks (#2146 - my bad, I should have rebased to include #1934 and the git hooks would have detected non-compliance locally).Naively, I trust the hooks to do the "right thing" and auto-fix as part of the
pre-commit.ci
workflow. I'd love to hear the flip argument as to why we shouldn't adopt that pattern.