Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release action #2172

Merged
merged 4 commits into from
May 17, 2023
Merged

Update release action #2172

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
614bd7a
CI: Run release action on release publication
dopplershift Apr 24, 2023
63986ab
CI: Make release workflow two separate build and publish jobs
dopplershift Apr 24, 2023
de45e71
CI: Swap to a pinned version of the PyPA package
dopplershift Apr 24, 2023
b074fdc
CI: Switch PyPI release to use "trusted publishing"
dopplershift Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Build and upload to PyPI

# Only build on tagged releases
# Only build on published releases
on:
push:
tags:
- '*'
release:
types:
- published
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a release guide to explain what we need to do to trigger this? I assume it is "go to GitHub and publish a release" because tagging via command line and pushing a tag is not good enough here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, we can stick with "tag and push" if we want, I just looked and saw we were already using the GitHub releases feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, I've been making releases through the web interface.


jobs:
build:
Expand Down Expand Up @@ -32,8 +32,32 @@ jobs:
- name: Create sdist
run: python setup.py build_ext sdist

- name: Publish Package
uses: pypa/gh-action-pypi-publish@master
- name: Save built packages as artifact
uses: actions/upload-artifact@v3
with:
user: __token__
password: ${{ secrets.pypi_token }}
name: packages-${{ runner.os }}-${{ matrix.python-version }}
path: dist/
if-no-files-found: error
retention-days: 5

publish:
name: Publish to PyPI
needs: build
environment:
name: PyPI
url: https://pypi.org/project/cartopy
permissions:
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
runs-on: ubuntu-18.04

steps:
- name: Download packages
uses: actions/download-artifact@v3

- name: Consolidate packages for upload
run: |
mkdir dist
cp packages-*/* dist/
greglucas marked this conversation as resolved.
Show resolved Hide resolved

- name: Publish Package
uses: pypa/[email protected]