Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Update Lambert Conformal test tolerances #2209

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

greglucas
Copy link
Contributor

PROJ 9.2+ has changed some of the Lambert Conformal test values as well. We got some of these in #2145 but LambertConformal also needed to be updated. The lower y-bound does seem a bit extreme here, but I think it is really pretty minimal in practice and just a matter of the x-boundary locations changing slightly and thus this value also changes now.

closes #2193

PROJ 9.2+ has changed some of the Lambert Conformal test values
@greglucas
Copy link
Contributor Author

I decided to plot this and visually expect what was going on. This test is quite sensitive because it is so far zoomed out. Now the new values are slightly more zoomed in. But, this is all related to PROJ tolerances, so I'm going to merge to start passing CI again.

import matplotlib.pyplot as plt
import cartopy.crs as ccrs

s_pole_crs = ccrs.LambertConformal(standard_parallels=[-1])
ax = plt.figure().add_subplot(1, 1, 1, projection=s_pole_crs)
ax.coastlines()
print(s_pole_crs.x_limits)
print(s_pole_crs.y_limits)

plt.show()

@greglucas greglucas merged commit b1e7252 into SciTools:main Jul 14, 2023
@greglucas greglucas deleted the tst-proj9.2 branch July 14, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with PROJ 9.2
1 participant