Pass options of stock_img to imshow #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartlixx
force-pushed
the
alpha_stock_img
branch
from
58883af
to
bbc4ec6
Compare
dopplershift
approved these changes
Aug 7, 2023
greglucas
reviewed
Aug 13, 2023
lib/cartopy/mpl/geoaxes.py
Outdated
| the Natural Earth shaded relief raster. | ||
| Currently, the only (and default) option for image is a downsampled | ||
| version of the Natural Earth shaded relief raster. Other options | ||
| (e.g., alpha) will be passed to func:`self.imshow`. |
There was a problem hiding this comment.
Suggested change
| (e.g., alpha) will be passed to func:`self.imshow`. | |
| (e.g., alpha) will be passed to :func:`self.imshow`. |
I think you need an extra colon in front of function to get that rendered properly by sphinx.
Edit: maybe even specifying Geoaxes rather than self ~.GeoAxes.imshow, or something like that.
There was a problem hiding this comment.
Thanks. I have made the corresponding changes.
smartlixx
force-pushed
the
alpha_stock_img
branch
from
bbc4ec6
to
c16a9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This will solve the problem raised by #2179
Implications
stock_imgcan accept more options, which will be dealt with byself.imshow.Closes #2179