-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xfails to current owslib failures #2264
Conversation
This adds xfails to the NASA server requests that are failing due to upstream issues that we can't control. This can be reverted if/when NASA or owslib update their codebases.
The current url was returning a 404. I looked for the same image name elsewhere on NASA and found this spot which looks reasonable.
646575e
to
dbdcfa1
Compare
docs/source/conf.py
Outdated
@@ -93,6 +93,13 @@ | |||
sphinx_gallery_conf = { | |||
'capture_repr': (), | |||
'examples_dirs': ['../../examples'], | |||
# NASA wmts servers are returning bad content metadata | |||
"expected_failing_examples": [ | |||
'../../examples/scalar_data/eyja_volcano.py', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like these two are flaky right now. I get failures when I remove them. I get failures when I add them :) Not sure if there is a way to say something is flaky in sphinx gallery?
'../../examples/scalar_data/eyja_volcano.py', | |
'../../examples/scalar_data/eyja_volcano.py', | |
'../../examples/web_services/image_tiles.py', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the Stamen tiles have moved https://stackoverflow.com/questions/77248120/stamen-terrain-map-not-working-in-cartopy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I did not realize that was going away. Let's follow that up in a separate PR then and leave the docs failing here for now.
dbdcfa1
to
d16768e
Compare
This adds xfails to all of the 10 current failures in the test suite. It also adds the failing documentation examples to the expected failures there as well.
In addition, running the examples locally I noticed that there is now a 404 from the Vesta image example, so another commit to change the URL for that example.